[gw api] Fix overwrite of route status #4309
Merged
+215
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
shuqz
reviewed
Aug 15, 2025
| @@ -11,7 +11,7 @@ spec: | |||
| kind: IngressClassParams | |||
| listKind: IngressClassParamsList | |||
| plural: ingressclassparams | |||
| singular: ingressclassparam | |||
| singular: ingressclassparams | |||
There was a problem hiding this comment.
why make singular same as plural? i thought there was a PR several days ago to fix it: 3174f96
|
/approved |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a possibility for the Gateway reconciler to enter an infinite loop when there's a partially working route. The flow is that a route gets it's status updated to accepted = false, however the previous implementation would always set all route statuses that got loaded to accepted = true. This behavior would cause the status to get overwritten and cause another gateway reconcile loop to get kicked off.
I approached the fix by refactoring the code to do route status updates in one place, and removed the route reconciler injection in other places and centralized the reconciler enqueue in the route mapper. By centralizing the enqueue logic, I was able to implement dedupe logic to prevent one reconcile cycle from writing a route status more than once.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯