Skip to content

Conversation

aschaber1
Copy link

Issue

This pull request introduces a new annotation, service.beta.kubernetes.io/aws-load-balancer-eip-tags, allowing users to dynamically assign Elastic IPs (EIPs) to an internet-facing Network Load Balancer (NLB) based on their AWS tags.

We don't want to hardcode certain IP allocations, and unfortunately the NLB does not support selecting IPs directly from an IPAMPool.

Description

This change adds a new annotation, service.beta.kubernetes.io/aws-load-balancer-eip-tags, that enables selecting unassociated EIPs for an internet-facing NLB by their tags instead of their specific allocation IDs. This simplifies the process for users who manage many EIPs, as they no longer need to manually find and specify individual allocation IDs.

The annotation's value is a comma-separated list of key=value pairs, which the controller uses to filter available EIPs. It finds all unassociated EIPs that match all specified tags. The controller then assigns these EIPs to the NLB, ensuring there are enough matching EIPs for the number of subnets the NLB is deployed in. This new annotation provides a more flexible way to manage and assign static IPs to NLBs.

This functionality complements the existing service.beta.kubernetes.io/aws-load-balancer-eip-allocations annotation, offering an alternative for EIP management.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aschaber1
Once this PR has been reviewed and has the lgtm label, please assign shraddhabang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

linux-foundation-easycla bot commented Aug 22, 2025

CLA Signed

  • ✅login: aschaber1 / name: Alexander Schaber / (6a26823)
  • ✅login: aschaber1 / name: Alexander Schaber / (6a26823, 36b6712)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @aschaber1!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @aschaber1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants