Skip to content

Conversation

dongjiang1989
Copy link
Contributor

No description provided.

Signed-off-by: dongjiang <dongjiang1989@126.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2025
@sbueringer
Copy link
Member

sbueringer commented Sep 11, 2025

Is there a need for this release?

Every envtest release requires some manual work today and I would prefer not doing this for every patch release if not needed

(xref: #1113)

@dongjiang1989
Copy link
Contributor Author

dongjiang1989 commented Sep 12, 2025

Is there a need for this release?

Every envtest release requires some manual work today and I would prefer not doing this for every patch release if not needed

(xref: #1113)

Thanks @sbueringer
Got it.

Can we add GitHub Actions to create it automatically? Keep 1-2 quarters of data for different users. 🤔

@sbueringer
Copy link
Member

We had a GitHub action, it just broke. See: #1113 (comment)

@sbueringer
Copy link
Member

sbueringer commented Sep 12, 2025

I'll cut a release for v1.34.1 next week. v1.34.0 has an issue that produces a lot of warnings so v1.34.1 would be good

@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2025
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f7bcf8c81ffdd03dc0f6e7acd4a21f7b4d4d72bd

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dongjiang1989, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit ac05d55 into kubernetes-sigs:main Sep 15, 2025
11 checks passed
@dongjiang1989 dongjiang1989 deleted the update-envtest-v1.34.1 branch September 15, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants