[WIP] Move tool management to its own go.mod #4141
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XL
| --config=crd-ref-docs.yaml \ | ||
| --renderer=markdown \ | ||
| --output-path=${PWD}/site-src/reference/specx.md | ||
| hack/mkdocs/generate.sh |
There was a problem hiding this comment.
do we have a verify job that validates the generated code is correct before merging?
There was a problem hiding this comment.
This generated file is never merged. The spec.md and specx.md are actually ignored (.gitignore). I kinda moved the job here, but in fact we are taking care of it here: #4132
Which reminds me I will fix the makefile there
There was a problem hiding this comment.
fixed on the other PR, once it is merged I can get rid of the change here :)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: howardjohn, rikatz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rikatz
force-pushed
the
remove-tools-from-go-mod
branch
from
68fd566 to
d4b55dc
Compare
k8s-ci-robot
added
size/XXL
| set -o pipefail | ||
|
|
||
| GOPATH=${GOPATH:-$(go env GOPATH)} | ||
| TOOLSMODFILE=${TOOLSMODFILE:-tools/go.mod} |
| # throw away | ||
| new_report="$(mktemp -t "$(basename "$0").api_violations.XXXXXX")" | ||
|
|
||
| TOOLSMODFILE="${TOOLSMODFILE:-$SCRIPT_ROOT/tools/go.mod}" |
| readonly GOFLAGS="-mod=readonly" | ||
| readonly GOPATH="$(mktemp -d)" | ||
| readonly MIN_REQUIRED_GO_VER="$(go list -m -f '{{.GoVersion}}')" | ||
| readonly MIN_REQUIRED_GO_VER="$(go list -m -f '{{.GoVersion}}' |head -n1)" |
There was a problem hiding this comment.
This is required because workspace now shows different go versions / lines
There was a problem hiding this comment.
This can be replaced by go list -m -f '{{.GoVersion}}' sigs.k8s.io/gateway-api
| SchemaProps: spec.SchemaProps{ | ||
| Description: "AllowedRoutes defines which Routes may be attached to this Listener.", | ||
| Type: []string{"object"}, | ||
| Type: []string{"object"}, |
There was a problem hiding this comment.
discard this, I guess we already fixed it on another PR
|
One extra comment: We may need a new verify that checks if all the go.mod are tidy'd now |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR moves our tool management out of the main
go.modfile, to its own file and relying on the newly addedgo toolcommand from Go 1.24Which issue(s) this PR fixes:
Part of #3318 (should add the structured management later)
Does this PR introduce a user-facing change?: