[WIP][DNM-2] Clean up Publish and Unpublish calls to speed up operations #1003
+81
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kishen-v The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
kishen-v
force-pushed
the
test-speedup
branch
from
b33fead to
79f7ef9
Compare
kishen-v
commented
Nov 13, 2025
| if err != nil { | ||
| if strings.Contains(strings.ToLower(err.Error()), ErrVolumeNotFound.Error()) { | ||
| klog.Warningf("Volume %s not found, assuming deleted", volumeID) | ||
| return nil | ||
| } | ||
| return err | ||
| } |
Contributor
Author
There was a problem hiding this comment.
If the volume not found error is not handled:
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
...
Warning VolumeFailedDelete 58s (x3 over 3m10s) powervs.csi.ibm.com_powervs-csi-controller-9f7dfd45b-4vnps_9219da62-c812-4d8f-9868-c84afca35d70 rpc error: code = Internal desc = Could not delete volume ID "44ccac77-b0ad-4880-a7d1-c8880151d07b": failed to perform Delete Volume Operation for volume 44ccac77-b0ad-4880-a7d1-c8880151d07b with error [DELETE /pcloud/v1/cloud-instances/{cloud_instance_id}/volumes/{volume_id}][404] pcloudCloudinstancesVolumesDeleteNotFound {"description":"volume does not exist. ID: 44ccac77-b0ad-4880-a7d1-c8880151d07b","error":"volume not found"}
With the check, #754 can be mitigated.
k8s-ci-robot
added
the
needs-rebase
kishen-v
force-pushed
the
test-speedup
branch
from
d1616db to
71002d5
Compare
k8s-ci-robot
removed
the
needs-rebase
kishen-v
force-pushed
the
test-speedup
branch
from
71002d5 to
d2a26d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR makes changes around Publish and Unpublish stages which improves the time taken to claim and unclaim volumes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: