[WIP] Changing build and sign to use Buildah instead of Kaniko container #1177
+285
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @TomerNewman. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
- Coverage 79.09% 73.39% -5.70%
==========================================
Files 51 66 +15
Lines 5109 5894 +785
==========================================
+ Hits 4041 4326 +285
- Misses 882 1400 +518
+ Partials 186 168 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TomerNewman
force-pushed
the
buildah
branch
2 times, most recently
from
b9ad744 to
ab20c33
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomerNewman, yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/XXL
TomerNewman
force-pushed
the
buildah
branch
2 times, most recently
from
6febb63 to
6a384a0
Compare
k8s-ci-robot
added
size/L
TomerNewman
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
ybettan
reviewed
Sep 2, 2025
| fieldPath: metadata.namespace | ||
| - name: RELATED_IMAGE_BUILD | ||
| value: gcr.io/kaniko-project/executor:latest | ||
| value: quay.io/buildah/stable:latest |
There was a problem hiding this comment.
Is this the official image that is being used by the u/s Shipwright project?
(I don't remember if when we tested it it was with the u/s version of Shipwright)
There was a problem hiding this comment.
they use in their samples quay.io/containers/buildah:v1.40.1
and bump it each time.
shipwright-io/build@10936ee
There was a problem hiding this comment.
in their official docs (buildah)
container images will be available at https://quay.io/repository/buildah/stable and https://quay.io/repository/containers/buildah.
There was a problem hiding this comment.
Ack. Then let's use the official one as you did. Is there a way to use a specific version instead of latest? I think we should use v1.41.3 instead of latest - we don't want things to start breaking under our legs.
|
What will all the rest of the kaniko refrences? |
ybettan
reviewed
Sep 2, 2025
| template.ParseFS(templateFS, "templates/Dockerfile.gotmpl"), | ||
| ) | ||
|
|
||
| func formatBuildArgs(buildArgs []kmmv1beta1.BuildArg) string { |
There was a problem hiding this comment.
Should we put this method in the BuildArgOverrider interface?
ybettan
reviewed
Sep 2, 2025
Comment on lines
119
to
122
| const ( | ||
| Build BuildOperation = iota | ||
| Sign | ||
| ) |
There was a problem hiding this comment.
Can we use the API's BuildOrSignAction instead of defining a new "type"?
ybettan
reviewed
Sep 2, 2025
| pushDescription = "signed image" | ||
| } | ||
|
|
||
| script := fmt.Sprintf(` |
There was a problem hiding this comment.
Any reason we are not using go templates? Like we did until now for signing?
I will look about the rest but regarding the CRD I thought that if we decide to change it, we can do it in a different PR. |
Because Kaniko is archived and thus not supported, it would be wise to change the build and sign feature to use buildah container instead of kaniko.
TomerNewman
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Kaniko is archived and thus not supported, it would be wise to change the build and sign feature to use Buildah container instead of Kaniko.
That way we can also match the build and sign d/s to behave the same.
/cc @ybettan @yevgeny-shnaidman