✨ (go/v4): scaffold kube-api-linter support in new projects #4941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
add-kpal-linter-otherway
branch
3 times, most recently
from
444bd36 to
6bda013
Compare
JoelSpeed
reviewed
Jul 21, 2025
camilamacedo86
force-pushed
the
add-kpal-linter-otherway
branch
8 times, most recently
from
85696c0 to
2f745c5
Compare
k8s-ci-robot
added
the
needs-rebase
camilamacedo86
force-pushed
the
add-kpal-linter-otherway
branch
from
2f745c5 to
6a5c28f
Compare
k8s-ci-robot
removed
the
needs-rebase
camilamacedo86
force-pushed
the
add-kpal-linter-otherway
branch
from
6a5c28f to
96e5382
Compare
k8s-ci-robot
added
size/XL
camilamacedo86
force-pushed
the
add-kpal-linter-otherway
branch
2 times, most recently
from
ecd247e to
8fcd00e
Compare
k8s-ci-robot
added
size/L
camilamacedo86
force-pushed
the
add-kpal-linter-otherway
branch
2 times, most recently
from
787744d to
3ca5994
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
add-kpal-linter-otherway
branch
from
3ca5994 to
08a0d45
Compare
camilamacedo86
changed the title
k8s-ci-robot
added
do-not-merge/invalid-commit-message
Remove omitempty from JSON tags on nested struct fields such as metav1 ObjectMeta Status and metav1 ListMeta in API type scaffolds The omitempty tag has no effect on nested structs in Go and triggers linter warnings For Go version 1.24+ and later omitzero correctly handles nested structs and omits them when empty making omitempty redundant and misleading The optional markers already indicate optional fields for CRD schema generation Updated JSON tags: - metav1 ObjectMeta metadata omitempty omitzero becomes metadata omitzero - Status fields status omitempty omitzero becomes status omitzero - metav1 ListMeta metadata omitempty becomes metadata omitzero This resolves linter warnings from gopls modernize analyzer and kube api linter while maintaining correct behavior for projects using Go 1.24+ Signed-off-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
camilamacedo86
force-pushed
the
add-kpal-linter-otherway
branch
from
2baf23a to
93ca425
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
Contributor
|
@camilamacedo86: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.custom-gcl.yml, adds Makefile and CI hooks, and enables thekubeapilintermodule in.golangci.ymlso every new operator starts with CRD-focused linting out of the box.optionalfieldspointer policy defaults toWhenRequired, matching the kube-api-linter maintainers’ recommendation for CRDs and avoiding the stricter setting that targets core Kubernetes API types (kube-api-linter#128).Closes: #4809