-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🌱 chore: update the asciinema demo creation script #5068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wazery The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @wazery. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ce9b9ee
to
ada0506
Compare
desc "Initialize Go modules" | ||
run "go mod init demo.kubebuilder.io" | ||
desc "Check if Kubebuilder is installed" | ||
run "kubebuilder version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure if we need to start with it tbh.
b6ef9e6
to
2f5bdbe
Compare
b339d16
to
0e9254a
Compare
@@ -0,0 +1,108 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the Makefile if we have some targets that just creates the needed kind cluster for testing, but I saw it's tightly coupled in the test scripts, so thought of introducing this minimal script just for the demo.
I feel my reasoning is not good here, and it would be nicer if I just decoupled the kind cluster creation from the test scripts, yet it's outside the scope of this PR 🤔 .. just thinking outloud 😅
0e9254a
to
ee1f601
Compare
This is a PR to address the issue #4552 which enhances the current script that creates the
asciinema
demo recording, by having a minimal makefile target that generates the new recording and updates the root readme file.I also added a minimal script that sets up a minimal demo kind cluster so we can deploy into.