Skip to content

✨ feat: add e2e test to validate webhook conversion between versions #5069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

✨ feat: add e2e test to validate webhook conversion between versions #5069

wants to merge 1 commit into from
+109 −1

Conversation

wazery
Copy link
Contributor

@wazery wazery commented Sep 1, 2025 •
edited
Loading

This PR introduces an e2e test to validate webhook conversion between versions, as part of the multiversion tutorial e2e tests.

Fixes: #4255

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wazery
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @wazery. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wazery wazery force-pushed the w-webhook-conversion-e2e-test branch 2 times, most recently from 2fda561 to 681bf43 Compare September 1, 2025 19:56
@wazery wazery marked this pull request as ready for review September 1, 2025 22:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2025
camilamacedo86
camilamacedo86 requested changes Sep 2, 2025
View reviewed changes
@wazery wazery force-pushed the w-webhook-conversion-e2e-test branch from 681bf43 to d65d418 Compare September 2, 2025 13:19
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2025
@wazery wazery force-pushed the w-webhook-conversion-e2e-test branch 2 times, most recently from effbdb8 to 6d31a62 Compare September 2, 2025 13:42
@wazery wazery force-pushed the w-webhook-conversion-e2e-test branch 2 times, most recently from 9fab9f8 to 6d8d9f7 Compare September 2, 2025 15:35
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2025
@wazery wazery force-pushed the w-webhook-conversion-e2e-test branch 2 times, most recently from 583f9aa to e79777c Compare September 9, 2025 11:55
@wazery wazery force-pushed the w-webhook-conversion-e2e-test branch from e79777c to 941df82 Compare September 9, 2025 12:03
@vitorfloriano vitorfloriano mentioned this pull request Sep 12, 2025
Open
@camilamacedo86
Copy link
Member

camilamacedo86 commented Sep 13, 2025 •
edited
Loading

/ok-to-test

Thank you for the contirbution 🥇
But it is not really checking the conversion yet.
See how we do the same in our e2e tests, https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/e2e/v4/plugin_cluster_test.go#L389-L432

We would need to do something very similar to that.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2025
@camilamacedo86 camilamacedo86 added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add e2e test to validate webhook conversion from one version to another
3 participants
@wazery @k8s-ci-robot @camilamacedo86