-
Notifications
You must be signed in to change notification settings - Fork 1.6k
📖 (docs/infra): Migrate to mdBook v0.5.0 #5207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
📖 (docs/infra): Migrate to mdBook v0.5.0 #5207
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vitorfloriano The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @vitorfloriano. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5892069 to
0d68b62
Compare
505a8de to
977bac6
Compare
0264f19 to
5f1f791
Compare
|
@camilamacedo86 Now that mdBook v0.5.0 is out, I think this one is ready to ship. I believe the deployment is failing right now due to another Cloudflare global network issue, so I guess we need to wait and see what happens when it's fixed. |
The migration from mdbook v0.4.40 to v0.5.0 introduces a few nice features that will provide better UX and DX.
5f1f791 to
48653db
Compare
| additional-css = ["theme/css/markers.css", "theme/css/custom.css", "theme/css/version-dropdown.css"] | ||
| git-repository-url = "https://github.com/kubernetes-sigs/kubebuilder" | ||
| edit-url-template = "https://github.com/kubernetes-sigs/kubebuilder/edit/master/docs/book/{path}" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 Unfortunately, it's not possible to not fold deeply nested sections like those. See this comment from the maintainer.
I could, though, include more foldable sections, like this:
I could also make them foldable but open by default, but the deeply nested sections would still be folded:
This is simply a matter of config:
| [output.html.fold] | |
| enable = true | |
| level = 5 # 0 would be all folded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we not enable = false to not have this behaviour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we not
enable = falseto not have this behaviour?
@camilamacedo86 This config defaults to false. That's how it currently is. But the deep nested headers will always be folded, no matter the config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you find any way of reduce that, I think it would be great already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very confusing :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 I tweaked some CSS classes. See if you like it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deployment is not showing the changes in the last commit...🤔 Perhaps it's showing a cached version of the website?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
033e2d1 to
2ff9a5c
Compare



This PR migrates the Kubebuilder book from mdBook v0.4.40 to v0.5.0.
Since this is a breaking change, the custom preprocessors (literatego and markerdocs) had to be slightly adjusted. The mdBook parser also got stricter and some fixes were necessary. See the mdBook v0.5 migration guide.
mdBook v0.5.0 introduces fixes and a some nice features that could improve the book DX and UX. To name a few:
Related to #4862