-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update AEP-8026: Allow per-VPA component configuration parameters #8505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
vertical-pod-autoscaler/enhancements/8026-per-vpa-component-configuration/README.md
Show resolved
Hide resolved
vertical-pod-autoscaler/enhancements/8026-per-vpa-component-configuration/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
/label tide/merge-method-squash |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
/retitle Update AEP-8026: Allow per-VPA component configuration parameters |
This LGTM, but I believe it needs api-review If you agree, can you add the label? |
Thanks for the title fix :) |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still missing answer to
- How does setting these two work with the global flags?
from https://github.com/kubernetes/autoscaler/pull/8012/files#r2321376062
All the rest have been answered. Although nowhere in the doc you're discussing what alternatives for this particular setting (specifically I'm looking for answer why one field isn't sufficient) were considered and the reason for rejection.
vertical-pod-autoscaler/enhancements/8026-per-vpa-component-configuration/README.md
Outdated
Show resolved
Hide resolved
…nfiguration/README.md Co-authored-by: Maciej Szulik <soltysh@gmail.com>
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianmoisey, omerap12, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Addressing #8012 (comment)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
As I can see we can have OOM configuration at both VPA-level (using containerPolicy with "*") and container-level. While both approaches work technically, I would appreciate your thoughts on which approach is more appropriate. Currently, the proposal keeps it at container-level for consistency with other container policies, but I'm open to discussion.
Also note that
oomBumpUp
will be replacing the existing global configuration when specified in a VPA object - we can achieve the same capabilities with only one config value.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: