Skip to content

Conversation

omerap12
Copy link
Member

@omerap12 omerap12 commented Sep 6, 2025

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Addressing #8012 (comment)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

As I can see we can have OOM configuration at both VPA-level (using containerPolicy with "*") and container-level. While both approaches work technically, I would appreciate your thoughts on which approach is more appropriate. Currently, the proposal keeps it at container-level for consistency with other container policies, but I'm open to discussion.

Also note that oomBumpUp will be replacing the existing global configuration when specified in a VPA object - we can achieve the same capabilities with only one config value.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Sep 6, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/vertical-pod-autoscaler size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2025
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2025
@omerap12
Copy link
Member Author

omerap12 commented Sep 6, 2025

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 6, 2025
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@adrianmoisey
Copy link
Member

/retitle Update AEP-8026: Allow per-VPA component configuration parameters

@k8s-ci-robot k8s-ci-robot changed the title update AEP Update AEP-8026: Allow per-VPA component configuration parameters Sep 13, 2025
@adrianmoisey
Copy link
Member

This LGTM, but I believe it needs api-review

If you agree, can you add the label?

@omerap12
Copy link
Member Author

This LGTM, but I believe it needs api-review

If you agree, can you add the label?

Thanks for the title fix :)
/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Sep 14, 2025
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still missing answer to

  1. How does setting these two work with the global flags?

from https://github.com/kubernetes/autoscaler/pull/8012/files#r2321376062

All the rest have been answered. Although nowhere in the doc you're discussing what alternatives for this particular setting (specifically I'm looking for answer why one field isn't sufficient) were considered and the reason for rejection.

omerap12 and others added 2 commits October 10, 2025 16:18
…nfiguration/README.md

Co-authored-by: Maciej Szulik <soltysh@gmail.com>
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2025
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2025
@adrianmoisey
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianmoisey, omerap12, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 04f6147 into kubernetes:master Oct 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants