Skip to content

Conversation

hobti01
Copy link
Contributor

@hobti01 hobti01 commented Sep 23, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #8566

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added vpa.recommender to the cluster-autoscaler Helm chart, allowing VPA to use a specific recommender

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 23, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @hobti01. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/helm-charts size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-area labels Sep 23, 2025
@hobti01
Copy link
Contributor Author

hobti01 commented Sep 23, 2025

/area helm-charts
/area cluster-autoscaler

@k8s-ci-robot
Copy link
Contributor

@hobti01: The label(s) area/helm-chart cannot be applied, because the repository doesn't have them.

In response to this:

/area helm-chart
/area cluster-autoscaler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jackfrancis
Copy link
Contributor

@adrianmoisey @omerap12 could you confirm the VPA usage patterns here?

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2025
@hobti01
Copy link
Contributor Author

hobti01 commented Oct 7, 2025

Hi @jackfrancis @adrianmoisey I've updated based on the conversation. Is there something special I need to do for the Chart Test/Lint to be successful?
Also I did not squash based on the contrib suggestion, but happy to do that when you're ready.

@jackfrancis
Copy link
Contributor

@hobti01 did you generate the update to the README via running helm-docs?

@hobti01
Copy link
Contributor Author

hobti01 commented Oct 8, 2025

@hobti01 did you generate the update to the README via running helm-docs?

Thanks @jackfrancis, I missed the pre-commit section in the charts/README.md, this is now done.

Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hobti01, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9befb31 into kubernetes:master Oct 10, 2025
6 checks passed
@hobti01 hobti01 deleted the p-8566 branch October 10, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow VPA recommender to be specified

5 participants