-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-4188: update goals and apply latest template #5579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
matthyx
commented
Sep 29, 2025
- One-line PR description: update goals and apply latest template
- Issue link: KEP: New kubelet gRPC API with endpoint returning local pods information #4188
- Other comments:
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: matthyx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick scan and it looks ok to me.
cc @ajaysundark |
string podUID = 1; | ||
// PodGetResponse returns a v1.Pod. | ||
message PodGetResponse { | ||
v1.Pod pod = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's be very explicit in here suggesting that the pod is a full Pod as declared in https://github.com/kubernetes/kubernetes/blob/9343d041209560f487cdf9121d5400a5685fa27a/pkg/apis/core/types.go#L4570 and how the versioning will work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean Pod V2 ? (jocking...)
I think we never bothered about versioning the pod spec anywhere, how do you see it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to explain here where this type is coming from specifically. And the best we can do is to say that the type will be exactly the time for this version of kubelet (not for the version of API server for example).
Also if you can add info on how exactly it will be generated, it will be great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not doing any new generation, just using the existing k8s.io/api/core/v1/generated.proto
import "k8s.io/api/core/v1/generated.proto";
message GetPodResponse {
k8s.io.api.core.v1.Pod pod = 1;
}
But yes, it will be the latest core Pod API based on the version of Kubelet, so I suppose if you have a different versioned API server and kubelet, they might be serving different messages.
rpc GetPodStatus(PodStatusGetRequest) returns (PodStatusGetResponse) {} | ||
import "google/protobuf/field_mask.proto"; | ||
service Pods { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @deads2k specifically for this API review.
08ae9f9
to
07bd8c5
Compare
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
(sorry I didn't mean to close this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pod API versioning comment left. And clarify more about the filters