Skip to content

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Sep 29, 2025

  • One-line PR description: update goals and apply latest template
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: matthyx
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Sep 29, 2025
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Sep 29, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 29, 2025
Copy link
Member

@bowei bowei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick scan and it looks ok to me.

@ajaysundark
Copy link

cc @ajaysundark

string podUID = 1;
// PodGetResponse returns a v1.Pod.
message PodGetResponse {
v1.Pod pod = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be very explicit in here suggesting that the pod is a full Pod as declared in https://github.com/kubernetes/kubernetes/blob/9343d041209560f487cdf9121d5400a5685fa27a/pkg/apis/core/types.go#L4570 and how the versioning will work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean Pod V2 ? (jocking...)
I think we never bothered about versioning the pod spec anywhere, how do you see it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to explain here where this type is coming from specifically. And the best we can do is to say that the type will be exactly the time for this version of kubelet (not for the version of API server for example).

Also if you can add info on how exactly it will be generated, it will be great

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not doing any new generation, just using the existing k8s.io/api/core/v1/generated.proto

import "k8s.io/api/core/v1/generated.proto";

message GetPodResponse {
    k8s.io.api.core.v1.Pod pod = 1;
}

But yes, it will be the latest core Pod API based on the version of Kubelet, so I suppose if you have a different versioned API server and kubelet, they might be serving different messages.

rpc GetPodStatus(PodStatusGetRequest) returns (PodStatusGetResponse) {}
import "google/protobuf/field_mask.proto";
service Pods {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @deads2k specifically for this API review.

@matthyx matthyx force-pushed the 4188 branch 2 times, most recently from 08ae9f9 to 07bd8c5 Compare October 7, 2025 14:52
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx matthyx closed this Oct 7, 2025
@matthyx
Copy link
Contributor Author

matthyx commented Oct 8, 2025

(sorry I didn't mean to close this)

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pod API versioning comment left. And clarify more about the filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants