Skip to content

KEP-4540: Promote the CPUManager Policy Option strict-cpu-reservation to GA #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

KEP-4540: Promote the CPUManager Policy Option strict-cpu-reservation to GA #5587

merged 1 commit into from
Oct 15, 2025
+33 −22

Conversation

psasnal
Copy link
Contributor

@psasnal psasnal commented Sep 30, 2025

  • One-line PR description: Promote the CPUManager Policy Option strict-cpu-reservation to GA

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 30, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @psasnal!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @psasnal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Sep 30, 2025
@psasnal psasnal changed the title KEP-4540: Promote the CPUManager Policy Option strict-cpu-reservation… KEP-4540: Promote the CPUManager Policy Option strict-cpu-reservation to GA Sep 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 30, 2025
@ffromani
Copy link
Contributor

/ok-to-test

@haircommander can we include in 1.35? should be quick and painless, and I'm happy to shepard this one

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2025
@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2025
@psasnal
Copy link
Contributor Author

psasnal commented Sep 30, 2025

@soltysh Could you take a look and approve this PR?

@SergeyKanzhelev
Copy link
Member

@ffromani please be an approver here: #5595

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Oct 1, 2025
Open
12 tasks
@SergeyKanzhelev
Copy link
Member

/assign @ffromani

ffromani
ffromani reviewed Oct 3, 2025
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from sig-node perspective this is actually as simple as it looks.

@wendy-ha18
Copy link
Member

wendy-ha18 commented Oct 5, 2025 •
edited
Loading

Hi @ffromani @psasnal , I'm a SIG Node Wrangler for this KEP, as it has got LGTM from SIG Node, is it ready for PRR review?
Deadline for PRR Freeze will be on next week Thursday 9th October 2025 (AoE) / Friday 10th October 2025, 12:00 UTC

cc PRR reviewer for this KEP is @stlaz (shadow) and @soltysh I believe 😃

@SergeyKanzhelev
Copy link
Member

/lgtm from sig-node perspective this is actually as simple as it looks.

@ffromani please approve if this is ready to be merged

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2025
@ffromani
Copy link
Contributor

ffromani commented Oct 7, 2025

/lgtm

I can indeed approve but I would like PRR folks to have a look (cc @SergeyKanzhelev ). I'll give them some more time

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@ffromani
Copy link
Contributor

ffromani commented Oct 8, 2025

/approve

I was reminded a separate PRR approval is required anyway (thanks!)

stlaz
stlaz approved these changes Oct 10, 2025
View reviewed changes
Copy link
Member

@stlaz stlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
for PRR. I've gone through the questionnaire and everything seems to be in order.

cc @soltysh

@ffromani
Copy link
Contributor

ping @soltysh PTAL please, should be quick and painless (given the scope and #5587 (review))

soltysh
soltysh reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor ask, can you please update ##### e2e tests section with appropriate links to those tests, as requested in the template

Once update, please ping me on slack and I'll approve the PRR.

@psasnal
KEP-4540: Promote the CPUManager Policy Option strict-cpu-reservation…
8ec59ce 
… to GA

updated kep.yaml, removed references to Beta feature gate in README where needed, added info about e2e tests and testgrid links
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2025
@ffromani
Copy link
Contributor

/lgtm

AFAICT the comment has been addressed

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2025
soltysh
soltysh approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
the PRR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, psasnal, soltysh, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2a2b7ca into kubernetes:master Oct 15, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haircommander haircommander haircommander left review comments

@soltysh soltysh soltysh approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

+2 more reviewers

@ffromani ffromani ffromani left review comments

@stlaz stlaz stlaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stlaz stlaz

@haircommander haircommander

@ffromani ffromani

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

8 participants

@psasnal @k8s-ci-robot @ffromani @haircommander @SergeyKanzhelev @wendy-ha18 @soltysh @stlaz