-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Update Karpenter to v1.6.2 #17567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update Karpenter to v1.6.2 #17567
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override pull-kops-e2e-aws-upgrade-k129-ko129-to-k130-kolatest-karpenter |
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-aws-upgrade-k129-ko129-to-k130-kolatest-karpenter In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
FYI I started working on a model that translates an InstanceGroup to EC2NodeClass and NodePool resources: master...rifelpet:kops:karpenter-model I was imagining that we'd add a new karpenter controller to kops-controller that periodically fetches the instance groups (and this new userdata object) from VFS, generates the model, and reconciles the resulting resources. It should be straight forward to add models for other cloud providers too. |
Very nice @rifelpet, I think that is exactly the missing piece. This PR adds generates a file with the user data, which is not that easy to generate separately. This way, everything needed for generating the |
096f26e
to
7343e7b
Compare
c8e16df
to
5132f34
Compare
/test pull-kops-verify-terraform |
/override pull-kops-e2e-aws-karpenter |
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-aws-karpenter In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-kops-scenario-aws-karpenter |
93575b2
to
b84c2a4
Compare
/test pull-kops-scenario-aws-karpenter |
b84c2a4
to
1433cd1
Compare
1433cd1
to
3deb6b8
Compare
34ff97d
to
5914c55
Compare
40206be
to
a12909e
Compare
/test pull-kops-scenario-aws-karpenter |
a12909e
to
567fed4
Compare
567fed4
to
64a8e79
Compare
/test pull-kops-scenario-aws-karpenter |
/test pull-kops-kubernetes-e2e-ubuntu-gce-build |
/override pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons |
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm If others have opinions. |
/retest |
@hakman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@ameukam I think we decided to merge and wait for Peter's PR another 3 weeks. |
Iterating on updated Karpenter setup.
Includes:
kops-controller
to generate theEC2NodeClass
LaunchTemplate
generation, which can no longer be used by Karpenter./cc @rifelpet @justinsb @ameukam