feat: Add support for start/termination timestamp for init containers #2750
+72
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: onasser1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
mrueg
reviewed
Aug 27, 2025
internal/store/pod.go
Outdated
| func createPodInitContainerStateStartedFamilyGenerator() generator.FamilyGenerator { | ||
| return *generator.NewFamilyGeneratorWithStability( | ||
| "kube_pod_init_container_state_started", | ||
| "Start time in unix timestamp for an_init_pod container.", |
There was a problem hiding this comment.
Suggested change
| "Start time in unix timestamp for an_init_pod container.", | |
| "Start time in unix timestamp for an init container inside the pod.", |
internal/store/pod.go
Outdated
| "kube_pod_init_container_state_started", | ||
| "Start time in unix timestamp for an_init_pod container.", | ||
| metric.Gauge, | ||
| basemetrics.STABLE, |
There was a problem hiding this comment.
Suggested change
| basemetrics.STABLE, | |
| basemetrics.ALPHA, |
internal/store/pod.go
Outdated
| func createPodInitContainerStatusLastTerminatedTimestampFamilyGenerator() generator.FamilyGenerator { | ||
| return *generator.NewFamilyGeneratorWithStability( | ||
| "kube_pod_init_container_status_last_terminated_timestamp", | ||
| "Last terminated time for a pod init container in unix timestamp.", |
There was a problem hiding this comment.
Suggested change
| "Last terminated time for a pod init container in unix timestamp.", | |
| "Last terminated time for an init container inside a pod in unix timestamp.", |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Init Containers do not have timestamps for
LastTerminatedandstate_startedUnlike Containers, so we provide themHow does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
increases
Which issue(s) this PR fixes: (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged)Fixes #2627