feat: add kube_deployment_owner metric #2782
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nmn3m The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-triage
|
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
|
Could you provide some use cases for this metric? |
|
| basemetrics.ALPHA, | ||
| "", | ||
| wrapDeploymentFunc(func(d *v1.Deployment) *metric.Family { | ||
| labelKeys := []string{"owner_kind", "owner_name", "owner_is_controller"} |
There was a problem hiding this comment.
What are other possible values other than controller?
There was a problem hiding this comment.
Application or custom resources
There was a problem hiding this comment.
Should we use an enum instead of boolean here?
There was a problem hiding this comment.
why we should do this?, I found that owner_is_controller is used in multiple workload like pods, jobs and replicaset, all of them is in boolean form
What this PR does / why we need it:
This PR adds a new metric
kube_deployment_ownerto track ownership information for Deployments. This is particularly useful for identifying Deployments managed by Operators or other controllers in the Kubernetes ecosystem. The metric includes information about the owner's kind, name, and whether it's a controller, making it easier to understand the ownership hierarchy in clusters.How does this change affect the cardinality of KSM: increases cardinality
This change adds one new metric with additional labels (
owner_kind,owner_name,owner_is_controller) for each Deployment in the cluster.Which issue(s) this PR fixes:
Fixes #2674
The new metric provides the following information: