feat: Added a workflow for automating pre-release PR #2787
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Rishab87 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Rishab87
changed the title
k8s-ci-robot
added
the
size/L
.github/workflows/pre-release.yml
Outdated
| git config --local user.email "ksm-release-bot@mock-k8s.io" | ||
| git config --local user.name "KSM Release Bot" |
There was a problem hiding this comment.
Could these be pointed to the person invoking the release instead?
.github/workflows/pre-release.yml
Outdated
| git config --local user.name "KSM Release Bot" | ||
| git add . | ||
| git commit -m "chore: Cut ${{ inputs.new_version }}" | ||
| MAJOR_MINOR_VERSION=$(echo "${{ inputs.new_version }}" | sed 's/^v//' | cut -d. -f1,2) |
.github/workflows/pre-release.yml
Outdated
| - name: Validate docs | ||
| run: make doccheck | ||
| - name: Validate manifests | ||
| run: make validate-manifests | ||
| - name: Validate go modules | ||
| run: make validate-modules |
There was a problem hiding this comment.
I'd like to see these done before testing steps.
| run: make validate-manifests | ||
| - name: Validate go modules | ||
| run: make validate-modules | ||
| - name: Create a pull request |
There was a problem hiding this comment.
I'd appreciate if the longer lines could be broken (using multi-line separators) down and commented for this step.
Rishab87
force-pushed
the
pre-release-workflow
branch
from
c0d1c8b to
e6bd578
Compare
|
@rexagod I've addressed all the reviews, can you please re-review again? |
What this PR does / why we need it:
This PR adds a workflow for automating the pre-release PR creation process. It runs all the commands mentioned in
RELEASE.mdfor pre release as well as all the tests.Test runs: Rishab87#8
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
does not changes
Which issue(s) this PR fixes: (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged)Related to #2756
To be merged after #2769