Skip to content

POC: Add a thread safe store that requires no read locking #133241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

POC: Add a thread safe store that requires no read locking #133241

wants to merge 4 commits into from
+3,544 −10

Conversation

alvaroaleman
Copy link
Member

This change adds a thread safe store that doesn't require any readlocking for the informer cache. Should not be merged in its current form, as this new store is used unconditionally.

See #130767 for more context.

/sig scalability
/sig api-machinery
/kind feature

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 27, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alvaroaleman
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from adrianmoisey, aojea and a team July 27, 2025 15:42
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Jul 27, 2025
@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Jul 27, 2025
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Jul 27, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Jul 27, 2025
@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jul 27, 2025
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Jul 27, 2025
@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Jul 27, 2025
@alvaroaleman alvaroaleman force-pushed the threadsafemvccstore branch 4 times, most recently from f06fccc to 3031e19 Compare July 27, 2025 17:25
@alvaroaleman alvaroaleman changed the title Add a thread safe store that requires no read locking POC: Add a thread safe store that requires no read locking Jul 27, 2025
@alvaroaleman
Add a thread safe store that requires no read locking
f96815c 
This change adds a thread safe store that doesn't require any
readlocking for the informer cache. Should not be merged in its current
form, as this store is used unconditionally.

See kubernetes#130767 for more
context.
@alvaroaleman alvaroaleman force-pushed the threadsafemvccstore branch from 3031e19 to f96815c Compare July 27, 2025 18:21
@alvaroaleman alvaroaleman mentioned this pull request Jul 27, 2025
Open
@enj enj moved this to Needs Triage in SIG Auth Jul 28, 2025
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 28, 2025
@alvaroaleman alvaroaleman force-pushed the threadsafemvccstore branch from 136687d to 9db71de Compare July 29, 2025 02:38
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 29, 2025
@dims
Copy link
Member

dims commented Jul 29, 2025

@alvaroaleman the repo looks frozen - https://github.com/benbjohnson/immutable - is there something better/newer/supported? cc @liggitt

@alvaroaleman
Copy link
Member Author

Did some benchmarking of the original performance vs iradix vs btree vs immutable map, as expected there is some slowdown everywhere and especially in inserts, but the insert slowdown for the btree and the immutable map is pretty drastic, ~10x slower in time, ~100x/30x mem usage: https://gist.github.com/alvaroaleman/848c6061fd5a29aa187ebf08710821f1

@alvaroaleman
Copy link
Member Author

@alvaroaleman the repo looks frozen - https://github.com/benbjohnson/immutable - is there something better/newer/supported? cc @liggitt

Thanks! I added the commit because I wanted to benchmark different underlying datastructures, see #133241 (comment). It looks like all except the immutable radix cause very drastic performance degradation

@k8s-ci-robot
Copy link
Contributor

@alvaroaleman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-dependencies 9db71de link true /test pull-kubernetes-dependencies
pull-kubernetes-linter-hints 9db71de link false /test pull-kubernetes-linter-hints
pull-kubernetes-verify 9db71de link true /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmoisey adrianmoisey Awaiting requested review from adrianmoisey

@aojea aojea Awaiting requested review from aojea

Assignees
No one assigned
Labels
area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Status: 🆕 New
SIG Auth
Status: Needs Triage
SIG CLI
Status: Needs Triage
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvaroaleman @k8s-ci-robot @dims