Skip to content

config: Use slices.Contains #21681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

config: Use slices.Contains #21681

merged 1 commit into from
Oct 8, 2025

Conversation

nirs
Copy link
Contributor

@nirs nirs commented Oct 2, 2025

Replace searching in slices with slices.Contains() and remove helper functions and tests.

Continuing modernization effort from #21430.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2025
@k8s-ci-robot k8s-ci-robot requested review from medyagh and prezha October 2, 2025 11:22
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 2, 2025
@nirs
Copy link
Contributor Author

nirs commented Oct 2, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 2, 2025
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@nirs
Copy link
Contributor Author

nirs commented Oct 2, 2025

/retest-this-please

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@nirs nirs force-pushed the slices-contains branch from 35d37c5 to 06ea7ea Compare October 2, 2025 19:46
medyagh
medyagh reviewed Oct 2, 2025
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so satisfying to see all those for loops gone !

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@nirs
Copy link
Contributor Author

nirs commented Oct 6, 2025

/retest-this-please

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@nirs nirs force-pushed the slices-contains branch from 06ea7ea to ff801e3 Compare October 6, 2025 20:54
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@nirs
Copy link
Contributor Author

nirs commented Oct 7, 2025 •
edited
Loading

The only unexpected failure is: Docker_Linux

I think this is a flake since this test pass when I run integration tests on Fedora.

Example run on Fedora:

$ make integration TEST_ARGS="-minikube-start-args='--driver=docker' -test.run=TestMissingContainerUpgrade -test.count=10"
go build  -tags "" -ldflags="-X k8s.io/minikube/pkg/version.version=v1.37.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.37.0-1758198818-20370 -X k8s.io/minikube/pkg/version.gitCommitID="ff801e3330dd49aa7ee258ec6e2e11c974a015c6" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v5" -o out/minikube k8s.io/minikube/cmd/minikube
go test -ldflags="-X k8s.io/minikube/pkg/version.version=v1.37.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.37.0-1758198818-20370 -X k8s.io/minikube/pkg/version.gitCommitID="ff801e3330dd49aa7ee258ec6e2e11c974a015c6" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v5" -v -test.timeout=90m ./test/integration --tags="integration " -minikube-start-args='--driver=docker' -test.run=TestMissingContainerUpgrade -test.count=10 2>&1 | tee "./out/testout_ff801e333.txt"
Found 10 cores, limiting parallelism with --test.parallel=5
=== RUN   TestMissingContainerUpgrade
=== PAUSE TestMissingContainerUpgrade
=== CONT  TestMissingContainerUpgrade
    version_upgrade_test.go:309: (dbg) Run:  /tmp/minikube-v1.32.0.1855084818 start -p missing-upgrade-240840 --memory=3072 --driver=docker
    version_upgrade_test.go:309: (dbg) Done: /tmp/minikube-v1.32.0.1855084818 start -p missing-upgrade-240840 --memory=3072 --driver=docker: (30.76306215s)
    version_upgrade_test.go:318: (dbg) Run:  docker stop missing-upgrade-240840
    version_upgrade_test.go:318: (dbg) Done: docker stop missing-upgrade-240840: (11.015356557s)
    version_upgrade_test.go:323: (dbg) Run:  docker rm missing-upgrade-240840
    version_upgrade_test.go:329: (dbg) Run:  out/minikube start -p missing-upgrade-240840 --memory=3072 --alsologtostderr -v=1 --driver=docker
    version_upgrade_test.go:329: (dbg) Done: out/minikube start -p missing-upgrade-240840 --memory=3072 --alsologtostderr -v=1 --driver=docker: (45.111740929s)
    helpers_test.go:175: Cleaning up "missing-upgrade-240840" profile ...
    helpers_test.go:178: (dbg) Run:  out/minikube delete -p missing-upgrade-240840
    helpers_test.go:178: (dbg) Done: out/minikube delete -p missing-upgrade-240840: (3.344740985s)
--- PASS: TestMissingContainerUpgrade (98.22s)
=== RUN   TestMissingContainerUpgrade
=== PAUSE TestMissingContainerUpgrade
=== CONT  TestMissingContainerUpgrade
    version_upgrade_test.go:309: (dbg) Run:  /tmp/minikube-v1.32.0.3141790665 start -p missing-upgrade-653100 --memory=3072 --driver=docker
    version_upgrade_test.go:309: (dbg) Done: /tmp/minikube-v1.32.0.3141790665 start -p missing-upgrade-653100 --memory=3072 --driver=docker: (27.864098208s)
    version_upgrade_test.go:318: (dbg) Run:  docker stop missing-upgrade-653100
    version_upgrade_test.go:318: (dbg) Done: docker stop missing-upgrade-653100: (1.163712511s)
    version_upgrade_test.go:323: (dbg) Run:  docker rm missing-upgrade-653100
    version_upgrade_test.go:329: (dbg) Run:  out/minikube start -p missing-upgrade-653100 --memory=3072 --alsologtostderr -v=1 --driver=docker
    version_upgrade_test.go:329: (dbg) Done: out/minikube start -p missing-upgrade-653100 --memory=3072 --alsologtostderr -v=1 --driver=docker: (43.429160659s)
    helpers_test.go:175: Cleaning up "missing-upgrade-653100" profile ...
    helpers_test.go:178: (dbg) Run:  out/minikube delete -p missing-upgrade-653100
    helpers_test.go:178: (dbg) Done: out/minikube delete -p missing-upgrade-653100: (3.415144398s)
--- PASS: TestMissingContainerUpgrade (83.60s)
=== RUN   TestMissingContainerUpgrade
=== PAUSE TestMissingContainerUpgrade
=== CONT  TestMissingContainerUpgrade
    version_upgrade_test.go:309: (dbg) Run:  /tmp/minikube-v1.32.0.2118512596 start -p missing-upgrade-008026 --memory=3072 --driver=docker
    version_upgrade_test.go:309: (dbg) Done: /tmp/minikube-v1.32.0.2118512596 start -p missing-upgrade-008026 --memory=3072 --driver=docker: (30.285990881s)
    version_upgrade_test.go:318: (dbg) Run:  docker stop missing-upgrade-008026
    version_upgrade_test.go:318: (dbg) Done: docker stop missing-upgrade-008026: (11.047471307s)
    version_upgrade_test.go:323: (dbg) Run:  docker rm missing-upgrade-008026
    version_upgrade_test.go:329: (dbg) Run:  out/minikube start -p missing-upgrade-008026 --memory=3072 --alsologtostderr -v=1 --driver=docker
    version_upgrade_test.go:329: (dbg) Done: out/minikube start -p missing-upgrade-008026 --memory=3072 --alsologtostderr -v=1 --driver=docker: (43.230486561s)
    helpers_test.go:175: Cleaning up "missing-upgrade-008026" profile ...
    helpers_test.go:178: (dbg) Run:  out/minikube delete -p missing-upgrade-008026
    helpers_test.go:178: (dbg) Done: out/minikube delete -p missing-upgrade-008026: (3.273613168s)
--- PASS: TestMissingContainerUpgrade (95.60s)
=== RUN   TestMissingContainerUpgrade
=== PAUSE TestMissingContainerUpgrade
=== CONT  TestMissingContainerUpgrade
    version_upgrade_test.go:309: (dbg) Run:  /tmp/minikube-v1.32.0.648746463 start -p missing-upgrade-511276 --memory=3072 --driver=docker
    version_upgrade_test.go:309: (dbg) Done: /tmp/minikube-v1.32.0.648746463 start -p missing-upgrade-511276 --memory=3072 --driver=docker: (28.736239499s)
    version_upgrade_test.go:318: (dbg) Run:  docker stop missing-upgrade-511276
    version_upgrade_test.go:318: (dbg) Done: docker stop missing-upgrade-511276: (11.032887781s)
    version_upgrade_test.go:323: (dbg) Run:  docker rm missing-upgrade-511276
    version_upgrade_test.go:329: (dbg) Run:  out/minikube start -p missing-upgrade-511276 --memory=3072 --alsologtostderr -v=1 --driver=docker
    version_upgrade_test.go:329: (dbg) Done: out/minikube start -p missing-upgrade-511276 --memory=3072 --alsologtostderr -v=1 --driver=docker: (42.640490145s)
    helpers_test.go:175: Cleaning up "missing-upgrade-511276" profile ...
    helpers_test.go:178: (dbg) Run:  out/minikube delete -p missing-upgrade-511276
    helpers_test.go:178: (dbg) Done: out/minikube delete -p missing-upgrade-511276: (3.332365219s)
--- PASS: TestMissingContainerUpgrade (93.33s)
=== RUN   TestMissingContainerUpgrade
=== PAUSE TestMissingContainerUpgrade
=== CONT  TestMissingContainerUpgrade
    version_upgrade_test.go:309: (dbg) Run:  /tmp/minikube-v1.32.0.3795411800 start -p missing-upgrade-330648 --memory=3072 --driver=docker
    version_upgrade_test.go:309: (dbg) Done: /tmp/minikube-v1.32.0.3795411800 start -p missing-upgrade-330648 --memory=3072 --driver=docker: (28.35251914s)
    version_upgrade_test.go:318: (dbg) Run:  docker stop missing-upgrade-330648
    version_upgrade_test.go:318: (dbg) Done: docker stop missing-upgrade-330648: (10.953536358s)
    version_upgrade_test.go:323: (dbg) Run:  docker rm missing-upgrade-330648
    version_upgrade_test.go:329: (dbg) Run:  out/minikube start -p missing-upgrade-330648 --memory=3072 --alsologtostderr -v=1 --driver=docker
    version_upgrade_test.go:329: (dbg) Done: out/minikube start -p missing-upgrade-330648 --memory=3072 --alsologtostderr -v=1 --driver=docker: (44.002923721s)
    helpers_test.go:175: Cleaning up "missing-upgrade-330648" profile ...
    helpers_test.go:178: (dbg) Run:  out/minikube delete -p missing-upgrade-330648
    helpers_test.go:178: (dbg) Done: out/minikube delete -p missing-upgrade-330648: (3.334467367s)
--- PASS: TestMissingContainerUpgrade (94.24s)
=== RUN   TestMissingContainerUpgrade
=== PAUSE TestMissingContainerUpgrade
=== CONT  TestMissingContainerUpgrade
    version_upgrade_test.go:309: (dbg) Run:  /tmp/minikube-v1.32.0.1081315247 start -p missing-upgrade-957889 --memory=3072 --driver=docker
    version_upgrade_test.go:309: (dbg) Done: /tmp/minikube-v1.32.0.1081315247 start -p missing-upgrade-957889 --memory=3072 --driver=docker: (28.17367617s)
    version_upgrade_test.go:318: (dbg) Run:  docker stop missing-upgrade-957889
    version_upgrade_test.go:318: (dbg) Done: docker stop missing-upgrade-957889: (11.057785313s)
    version_upgrade_test.go:323: (dbg) Run:  docker rm missing-upgrade-957889
    version_upgrade_test.go:329: (dbg) Run:  out/minikube start -p missing-upgrade-957889 --memory=3072 --alsologtostderr -v=1 --driver=docker
    version_upgrade_test.go:329: (dbg) Done: out/minikube start -p missing-upgrade-957889 --memory=3072 --alsologtostderr -v=1 --driver=docker: (44.249249071s)
    helpers_test.go:175: Cleaning up "missing-upgrade-957889" profile ...
    helpers_test.go:178: (dbg) Run:  out/minikube delete -p missing-upgrade-957889
    helpers_test.go:178: (dbg) Done: out/minikube delete -p missing-upgrade-957889: (3.320696896s)
--- PASS: TestMissingContainerUpgrade (95.46s)
=== RUN   TestMissingContainerUpgrade
=== PAUSE TestMissingContainerUpgrade
=== CONT  TestMissingContainerUpgrade
    version_upgrade_test.go:309: (dbg) Run:  /tmp/minikube-v1.32.0.1637472501 start -p missing-upgrade-779135 --memory=3072 --driver=docker
    version_upgrade_test.go:309: (dbg) Done: /tmp/minikube-v1.32.0.1637472501 start -p missing-upgrade-779135 --memory=3072 --driver=docker: (28.602053392s)
    version_upgrade_test.go:318: (dbg) Run:  docker stop missing-upgrade-779135
    version_upgrade_test.go:318: (dbg) Done: docker stop missing-upgrade-779135: (10.944726338s)
    version_upgrade_test.go:323: (dbg) Run:  docker rm missing-upgrade-779135
    version_upgrade_test.go:329: (dbg) Run:  out/minikube start -p missing-upgrade-779135 --memory=3072 --alsologtostderr -v=1 --driver=docker
    version_upgrade_test.go:329: (dbg) Done: out/minikube start -p missing-upgrade-779135 --memory=3072 --alsologtostderr -v=1 --driver=docker: (45.761714679s)
    helpers_test.go:175: Cleaning up "missing-upgrade-779135" profile ...
    helpers_test.go:178: (dbg) Run:  out/minikube delete -p missing-upgrade-779135
    helpers_test.go:178: (dbg) Done: out/minikube delete -p missing-upgrade-779135: (3.428656178s)
--- PASS: TestMissingContainerUpgrade (99.78s)
=== RUN   TestMissingContainerUpgrade
=== PAUSE TestMissingContainerUpgrade
=== CONT  TestMissingContainerUpgrade
    version_upgrade_test.go:309: (dbg) Run:  /tmp/minikube-v1.32.0.2692428517 start -p missing-upgrade-382263 --memory=3072 --driver=docker
    version_upgrade_test.go:309: (dbg) Done: /tmp/minikube-v1.32.0.2692428517 start -p missing-upgrade-382263 --memory=3072 --driver=docker: (27.62862983s)
    version_upgrade_test.go:318: (dbg) Run:  docker stop missing-upgrade-382263
    version_upgrade_test.go:318: (dbg) Done: docker stop missing-upgrade-382263: (11.020807903s)
    version_upgrade_test.go:323: (dbg) Run:  docker rm missing-upgrade-382263
    version_upgrade_test.go:329: (dbg) Run:  out/minikube start -p missing-upgrade-382263 --memory=3072 --alsologtostderr -v=1 --driver=docker
    version_upgrade_test.go:329: (dbg) Done: out/minikube start -p missing-upgrade-382263 --memory=3072 --alsologtostderr -v=1 --driver=docker: (43.037262723s)
    helpers_test.go:175: Cleaning up "missing-upgrade-382263" profile ...
    helpers_test.go:178: (dbg) Run:  out/minikube delete -p missing-upgrade-382263
    helpers_test.go:178: (dbg) Done: out/minikube delete -p missing-upgrade-382263: (3.404190433s)
--- PASS: TestMissingContainerUpgrade (92.90s)
=== RUN   TestMissingContainerUpgrade
=== PAUSE TestMissingContainerUpgrade
=== CONT  TestMissingContainerUpgrade
    version_upgrade_test.go:309: (dbg) Run:  /tmp/minikube-v1.32.0.2348669408 start -p missing-upgrade-678255 --memory=3072 --driver=docker
    version_upgrade_test.go:309: (dbg) Done: /tmp/minikube-v1.32.0.2348669408 start -p missing-upgrade-678255 --memory=3072 --driver=docker: (28.913057632s)
    version_upgrade_test.go:318: (dbg) Run:  docker stop missing-upgrade-678255
    version_upgrade_test.go:318: (dbg) Done: docker stop missing-upgrade-678255: (11.007592947s)
    version_upgrade_test.go:323: (dbg) Run:  docker rm missing-upgrade-678255
    version_upgrade_test.go:329: (dbg) Run:  out/minikube start -p missing-upgrade-678255 --memory=3072 --alsologtostderr -v=1 --driver=docker
    version_upgrade_test.go:329: (dbg) Done: out/minikube start -p missing-upgrade-678255 --memory=3072 --alsologtostderr -v=1 --driver=docker: (42.966768791s)
    helpers_test.go:175: Cleaning up "missing-upgrade-678255" profile ...
    helpers_test.go:178: (dbg) Run:  out/minikube delete -p missing-upgrade-678255
    helpers_test.go:178: (dbg) Done: out/minikube delete -p missing-upgrade-678255: (3.383125035s)
--- PASS: TestMissingContainerUpgrade (93.87s)
=== RUN   TestMissingContainerUpgrade
=== PAUSE TestMissingContainerUpgrade
=== CONT  TestMissingContainerUpgrade
    version_upgrade_test.go:309: (dbg) Run:  /tmp/minikube-v1.32.0.296068773 start -p missing-upgrade-828982 --memory=3072 --driver=docker
    version_upgrade_test.go:309: (dbg) Done: /tmp/minikube-v1.32.0.296068773 start -p missing-upgrade-828982 --memory=3072 --driver=docker: (27.878719317s)
    version_upgrade_test.go:318: (dbg) Run:  docker stop missing-upgrade-828982
    version_upgrade_test.go:318: (dbg) Done: docker stop missing-upgrade-828982: (11.093671582s)
    version_upgrade_test.go:323: (dbg) Run:  docker rm missing-upgrade-828982
    version_upgrade_test.go:329: (dbg) Run:  out/minikube start -p missing-upgrade-828982 --memory=3072 --alsologtostderr -v=1 --driver=docker
    version_upgrade_test.go:329: (dbg) Done: out/minikube start -p missing-upgrade-828982 --memory=3072 --alsologtostderr -v=1 --driver=docker: (39.699714014s)
    helpers_test.go:175: Cleaning up "missing-upgrade-828982" profile ...
    helpers_test.go:178: (dbg) Run:  out/minikube delete -p missing-upgrade-828982
    helpers_test.go:178: (dbg) Done: out/minikube delete -p missing-upgrade-828982: (3.447579707s)
--- PASS: TestMissingContainerUpgrade (89.66s)
PASS
Tests completed in 15m36.672589798s (result code 0)
ok  	k8s.io/minikube/test/integration	936.750s

@nirs nirs requested a review from medyagh October 7, 2025 19:50
@nirs nirs mentioned this pull request Oct 7, 2025
Merged
@nirs
Copy link
Contributor Author

nirs commented Oct 8, 2025

Docker_Linux tess also passed in #21625 when rebased on top of this PR.

@medyagh this is ready for merge.

@nirs
config: Use slices.Contains
595bbf5 
Replace searching in slices with slices.Contains() and remove helper
functions and tests.

Continuing modernization effort from kubernetes#21430.
@nirs nirs force-pushed the slices-contains branch from ff801e3 to 595bbf5 Compare October 8, 2025 13:09
@k8s-ci-robot
Copy link
Contributor

@nirs: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-minikube-integration 595bbf5 link true /test pull-minikube-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21681 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 42.6s    │ 43.5s                  │
│ enable ingress │ 19.0s    │ 15.9s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 42.1s 44.2s 40.7s 42.9s 43.3s
Times for minikube (PR 21681) start: 40.5s 41.1s 45.5s 44.3s 46.2s

Times for minikube ingress: 16.3s 15.8s 19.3s 15.8s 27.8s
Times for minikube (PR 21681) ingress: 16.4s 15.8s 15.8s 15.8s 15.9s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21681 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 24.0s    │ 23.1s                  │
│ enable ingress │ 11.9s    │ 11.5s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube ingress: 14.7s 10.6s 10.6s 12.6s 10.7s
Times for minikube (PR 21681) ingress: 12.7s 11.7s 11.7s 10.7s 10.7s

Times for minikube start: 22.9s 22.6s 24.7s 23.8s 25.9s
Times for minikube (PR 21681) start: 22.3s 22.6s 23.4s 24.4s 22.8s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21681 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 20.4s    │ 20.5s                  │
│ enable ingress │ 20.1s    │ 20.1s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 20.4s 21.4s 20.4s 20.2s 19.5s
Times for minikube (PR 21681) start: 20.4s 20.6s 19.9s 20.6s 20.9s

Times for minikube ingress: 20.1s 20.1s 20.1s 20.1s 20.1s
Times for minikube (PR 21681) ingress: 20.1s 20.1s 20.1s 20.1s 20.1s

@medyagh
Copy link
Member

medyagh commented Oct 8, 2025

/lgtm

@medyagh medyagh merged commit e4c8917 into kubernetes:master Oct 8, 2025
28 of 42 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, nirs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Windows (2 failed) TestErrorSpam/setup(gopogh) Unknown
Docker_Windows (2 failed) TestRunningBinaryUpgrade(gopogh) Unknown
Docker_Linux_containerd (2 failed) TestMultiNode/serial/AddNode(gopogh) 0.00% (chart)
Docker_Linux_containerd (2 failed) TestMultiNode/serial/MultiNodeLabels(gopogh) 0.00% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prezha prezha Awaiting requested review from prezha

@medyagh medyagh Awaiting requested review from medyagh

Assignees

@medyagh medyagh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nirs @minikube-pr-bot @k8s-ci-robot @medyagh