-
Notifications
You must be signed in to change notification settings - Fork 586
Fix: Correct netperf ReplicaSet flags in launch.go to allow pod startup #3369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: merdincz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @merdincz! |
Hi @merdincz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7df1d7a
to
c50deed
Compare
It is not code issue. It is caused by old, not rebuild, image which used by default sirot/netperf-latest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The
launch.go
file currently attempts to create a ReplicaSet for the netperf application using the--testFrom
and--testTo
flags. These flags are not recognized by the netperf image, causing an error that prevents the Pod from starting successfully.This PR removes the unsupported
--testFrom
and--testTo
flags from the ReplicaSet definition. With this change, the netperf Pods can start correctly and achieve a healthy state.Which issue(s) this PR fixes:
Fixes #2452
Special notes for your reviewer: