Skip to content

etcd: Add etcd functional tests presubmits for release-3.4 #34849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

etcd: Add etcd functional tests presubmits for release-3.4 #34849

wants to merge 1 commit into from

Conversation

joshjms
Copy link
Member

@joshjms joshjms commented May 25, 2025

@k8s-ci-robot k8s-ci-robot requested review from ivanvc and jmhbnz May 25, 2025 18:19
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. labels May 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joshjms
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label May 25, 2025
@joshjms
Copy link
Member Author

joshjms commented May 25, 2025

/hold

Let's wait until etcd-io/etcd#20021 is merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2025
@joshjms joshjms marked this pull request as draft May 26, 2025 03:52
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2025
@joshjms joshjms force-pushed the etcd-functional-release-3.4 branch from 1960da9 to 029362c Compare May 26, 2025 03:57
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 26, 2025
@joshjms joshjms marked this pull request as ready for review May 26, 2025 03:57
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2025
ivanvc
ivanvc reviewed May 27, 2025
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, @joshjms. Please take a look at my comments.

config/jobs/etcd/etcd-presubmits.yaml Outdated
Comment on lines 854 to 855
nodeSelector:
kubernetes.io/arch: amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by default everything runs on the AMD64 arch, so there's no need for this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I removed it

config/jobs/etcd/etcd-presubmits.yaml
- -c
- |
apt-get update && apt-get install -y netcat-openbsd
GOARCH=amd64 make test-functional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also remove GOARCH here, as it will run on amd64.

Suggested change
GOARCH=amd64 make test-functional
make test-functional

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But... other jobs define this. So, we may want to keep it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would tend to leave this in to keep the invocation appearances similar across all the jobs. Happy either way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave it then :)

config/jobs/etcd/etcd-presubmits.yaml Outdated
Comment on lines 848 to 853
requests:
cpu: "4"
memory: "2Gi"
limits:
cpu: "4"
memory: "2Gi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we establish these resource requests and limits? Do we need 4 CPUs? Is 2 Gi enough RAM?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the unit tests as reference. I think we can try let it run for a few times and tune it later. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They may be more resource-intensive. I suggest increasing the memory to avoid OOM kills once we merge the pull request. It's always easier to overprovision and fine-tune, rather than underprovision and try to get it up and running.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Will do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I increased it to 8Gi

@ivanvc ivanvc mentioned this pull request May 27, 2025
Open
15 tasks
@joshjms joshjms force-pushed the etcd-functional-release-3.4 branch from 029362c to d6e2ba5 Compare May 28, 2025 19:49
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 28, 2025
@joshjms joshjms force-pushed the etcd-functional-release-3.4 branch from d6e2ba5 to 8d6b23b Compare May 28, 2025 19:52
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 28, 2025
@joshjms
Copy link
Member Author

joshjms commented May 28, 2025

/retest

@joshjms joshjms force-pushed the etcd-functional-release-3.4 branch from 8d6b23b to dcbec28 Compare May 28, 2025 20:20
@joshjms
etcd: Add pull-etcd-functional presubmits for amd64
9c1a8c8 
Signed-off-by: joshjms <joshjms1607@gmail.com>
@joshjms joshjms force-pushed the etcd-functional-release-3.4 branch from dcbec28 to 9c1a8c8 Compare May 28, 2025 20:21
@ivanvc
Copy link
Member

ivanvc commented May 29, 2025

/close

We're not migrating functional tests. Refer to etcd-io/etcd#20021 (comment)

@k8s-ci-robot
Copy link
Contributor

@ivanvc: Closed this PR.

In response to this:

/close

We're not migrating functional tests. Refer to etcd-io/etcd#20021 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanvc ivanvc ivanvc left review comments

@jmhbnz jmhbnz Awaiting requested review from jmhbnz

Assignees
No one assigned
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshjms @k8s-ci-robot @ivanvc @jmhbnz