Skip to content

etcd: Add grpcproxy integration and e2e tests to release-3.4 #34891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

etcd: Add grpcproxy integration and e2e tests to release-3.4 #34891

merged 1 commit into from
Jun 2, 2025

Conversation

joshjms
Copy link
Member

@joshjms joshjms commented May 30, 2025

@joshjms
etcd: Add grpcproxy integration and e2e tests to release-3.4
86f40f2 
Signed-off-by: joshjms <joshjms1607@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 30, 2025
@joshjms
Copy link
Member Author

joshjms commented May 30, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2025
@joshjms
Copy link
Member Author

joshjms commented May 30, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2025
@ivanvc ivanvc mentioned this pull request May 30, 2025
Open
15 tasks
@ivanvc
Copy link
Member

ivanvc commented May 30, 2025

/hold for etcd-io/etcd#20063 to be merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2025
ivanvc
ivanvc approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks, @joshjms.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 30, 2025
jmhbnz
jmhbnz approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz, joshjms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ca88cf6 into kubernetes:master Jun 2, 2025
6 of 7 checks passed
@k8s-ci-robot
Copy link
Contributor

@joshjms: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-presubmits.yaml using file config/jobs/etcd/etcd-presubmits.yaml

In response to this:

Ref: #32754, etcd-io/etcd#20063

/cc @ivanvc @abdurrehman107

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanvc ivanvc ivanvc approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

@abdurrehman107 abdurrehman107 Awaiting requested review from abdurrehman107

Assignees

@ivanvc ivanvc

@jmhbnz jmhbnz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshjms @ivanvc @k8s-ci-robot @jmhbnz