-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add 1.33 sig node tests and remove 1.29/1.30 #34945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add 1.33 sig node tests and remove 1.29/1.30 #34945
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elieser1101 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -1,5 +1,5 @@ | |||
images: | |||
cos-dev: | |||
image_family: cos-109-lts | |||
image_family: cos-113-lts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do cos-121 to align supportability matrix better
@@ -1,5 +0,0 @@ | |||
images: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for not caching before. It looks like 1.30 is supported another 20 days: https://kubernetes.io/releases/#release-v1-30
Maybe we should not remove it just yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I see, would make sense to repurpose this PR to only drop 1.29 and add 1.33?
we can follow up dropping 1.30 once support is finally over, or do we prefer to just hod this PR? @SergeyKanzhelev
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #34927
removed 1.29 and 1.30. Please note that for 1.33 used kuebtest2 to add the test.
cc: @kannon92