Skip to content

[Scheduler] Graduate NodeInclusionPolicy to GA #49927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 6, 2025
Merged

[Scheduler] Graduate NodeInclusionPolicy to GA #49927

merged 4 commits into from
Apr 6, 2025

Conversation

kerthcet
Copy link
Member

Description

Issue

ref kubernetes/enhancements#3094

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/localization General issues or PRs related to localization area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes labels Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added language/bn Issues or PRs related to Bengali language language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/pl Issues or PRs related to Polish language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit ca6a227
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67e28cf7bc50680008b91082

@kerthcet kerthcet mentioned this pull request Feb 27, 2025
Open
12 tasks
@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ca6a227
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67e28cf726e8a20008bc8c5c
😎 Deploy Preview https://deploy-preview-49927--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kerthcet kerthcet force-pushed the cleanup/upgrade-nodeinclusionpolicy-ga branch from e32c776 to 6d820b6 Compare February 27, 2025 06:27
@tengqm
Copy link
Contributor

tengqm commented Feb 27, 2025

oh no, something is wrong from your client side.
You are supposed to base your commit on dev-1.33 branch HEAD. and commit to that branch.

@sftim
Copy link
Contributor

sftim commented Feb 27, 2025

/label tide/merge-method-squash

Ideally: squash this to 1 (or small n) commits, and force push. Then we can remove that label.

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 27, 2025
@kerthcet
Copy link
Member Author

will fix this when doc ready.

@kerthcet
Copy link
Member Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Feb 27, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Scheduling Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2025
@rayandas
Copy link
Member

rayandas commented Mar 25, 2025 •
edited
Loading

Hello @kerthcet 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th March 2025 18:00 PDT. Thank you!

@kerthcet kerthcet closed this Mar 25, 2025
@kerthcet kerthcet force-pushed the cleanup/upgrade-nodeinclusionpolicy-ga branch from 6d820b6 to edf6a64 Compare March 25, 2025 06:07
@github-project-automation github-project-automation bot moved this from Needs Triage to Closed in SIG Scheduling Mar 25, 2025
@kerthcet kerthcet force-pushed the cleanup/upgrade-nodeinclusionpolicy-ga branch from 9a576da to 24ea875 Compare March 25, 2025 06:21
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2025
@kerthcet
Graduate NodeInclusionPolicyInPodTopologySpread to GA
8664a6a 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet marked this pull request as ready for review March 25, 2025 06:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2025
@kerthcet
Copy link
Member Author

Hey @rayandas thanks for reminding, it's ready for review now.

@kerthcet
Copy link
Member Author

ping @kubernetes/sig-docs-en-owners

@dipesh-rawat
Copy link
Member

dipesh-rawat commented Mar 25, 2025 •
edited
Loading

/remove-language bn ja pl zh
/remove-area localization
/remove-area web-development

@k8s-ci-robot k8s-ci-robot removed area/localization General issues or PRs related to localization area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes language/bn Issues or PRs related to Bengali language language/ja Issues or PRs related to Japanese language language/pl Issues or PRs related to Polish language language/zh Issues or PRs related to Chinese language labels Mar 25, 2025
@kerthcet
Add toVersion for beta level
ca6a227 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@rayandas
Copy link
Member

rayandas commented Apr 3, 2025

Hello @kerthcet 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT.
This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs.
The status of this enhancement is marked as At risk for docs freeze. Thank you!

@tengqm
Copy link
Contributor

tengqm commented Apr 5, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2025
@kerthcet
Copy link
Member Author

kerthcet commented Apr 5, 2025

we still need a LGTM

@tengqm
Copy link
Contributor

tengqm commented Apr 6, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1453bf3f1276d9fb6b9a76758068930f0810dee9

@k8s-ci-robot k8s-ci-robot merged commit 6437ca9 into kubernetes:dev-1.33 Apr 6, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in SIG Scheduling Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
SIG Scheduling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kerthcet @tengqm @sftim @rayandas @dipesh-rawat @k8s-ci-robot