feat: add support for signature algorithm in cosign cert and kms veri… #1556
Conversation
yrsuthari
force-pushed
the
feat/add-signature-algorithm-support
branch
from
27bc1d9 to
71cbb31
Compare
| -----END PUBLIC KEY----- | ||
| ctlog: | ||
| ignoreSCT: true | ||
| pubkey: |- | ||
| -----BEGIN PUBLIC KEY----- | ||
| MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAE8nXRh950IZbRj8Ra/N9sbqOPZrfM | ||
| 5/KAQN0/KjHcorm/J5yctVd7iEcnessRQjU917hmKO6JWVGHpDguIyakZA== | ||
| MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEE8uGVnyDWPPlB7M5KOHRzxzPHtAy |
There was a problem hiding this comment.
i dont understand this change
| attestors: | ||
| - entries: | ||
| - keys: | ||
| kms: "awskms://[ENDPOINT]/[ID/ALIAS/ARN]" |
There was a problem hiding this comment.
I think we can just have one example of signature algorithm as it applies to all other types (key, kms, certs)
There was a problem hiding this comment.
@vishal-chdhry I've consolidated the signature algorithm examples into a single comprehensive example that shows how it works across all verification methods (keys, certificates, and KMS). This makes the documentation clearer and avoids redundancy since the functionality works the same way regardless of the verification method used.
The updated example includes all three use cases with clear comments, making it easier for users to understand how to use signature algorithms consistently across their infrastructure.
Let me know if you'd like any further adjustments to the documentation.
|
@yrsuthari - can you please address the review comments from Vishal? |
hi @JimBugwadia I have done so. |
yrsuthari
force-pushed
the
feat/add-signature-algorithm-support
branch
from
84ac393 to
bdc60f9
Compare
…fication Signed-off-by: Yogi Suthari <yrsuthari@gmail.com>
…charts Signed-off-by: Yogi Suthari <yrsuthari@gmail.com>
Fixes: kyverno#1415 Signed-off-by: Yogi Suthari <yrsuthari@gmail.com>
yrsuthari
force-pushed
the
feat/add-signature-algorithm-support
branch
from
bdc60f9 to
296ff83
Compare
|
Hi @JimBugwadia Can this be merged? Are there any other concerns to this regard? |
Fixes: #1415
Proposed Changes:
This PR enhances the Sigstore documentation by adding information about the signatureAlgorithm field support in:
These changes improve the documentation by showing users how to use different signature algorithms (sha224, sha256, sha384, sha512) with various verification methods in Kyverno policies.
Checklist
[x] I have read the contributing guidelines.
[x] I have inspected the website preview for accuracy.
[x] I have signed off my issue.