Skip to content

Conversation

tretter
Copy link
Contributor

@tretter tretter commented Jul 23, 2025

Description

Add the VENDOR_ID and MODEL_ID for the Maskrom mode of the Rockchip rk3568 and rk3588 to the possible matches for RKUSBLoader to allow using the RKUSBLoader with these SoCs.

With this change, labgrid-suggest recognizes Rockchip rk3568 and rk3588 SoCs if booted into Maskrom mode.

Checklist

  • PR has been tested:

Add the VENDOR_ID and MODEL_ID for the Maskrom mode of the Rockchip
rk3568 and rk3588 to the possible matches for RKUSBLoader to allow to
use the RKUSBLoader with these SoCs.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.6%. Comparing base (4398da7) to head (ce19201).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/resource/udev.py 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1701   +/-   ##
======================================
  Coverage    55.6%   55.6%           
======================================
  Files         172     172           
  Lines       13471   13471           
======================================
  Hits         7500    7500           
  Misses       5971    5971           
Flag Coverage Δ
3.10 55.6% <0.0%> (ø)
3.11 55.6% <0.0%> (ø)
3.12 55.6% <0.0%> (ø)
3.13 55.6% <0.0%> (ø)
3.9 55.7% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sjg20 sjg20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use this one instead?

#1702

@tretter tretter closed this Jul 24, 2025
@tretter tretter deleted the udev-add-rk3568-and-rk3588 branch July 29, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants