Skip to content

upgraded #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/Enums/Chart.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

namespace LaravelEnso\Charts\Enums;

enum Chart: string
{
case Bubble = 'bubble';
case Doughnut = 'doughnut';
case Line = 'line';
case Pie = 'pie';
case PolarArea = 'polarArea';
case Radar = 'radar';
}
13 changes: 0 additions & 13 deletions src/Enums/Charts.php

This file was deleted.

4 changes: 2 additions & 2 deletions src/Factories/Bubble.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use Illuminate\Support\Collection;
use Illuminate\Support\Traits\Conditionable;
use LaravelEnso\Charts\Enums\Charts;
use LaravelEnso\Charts\Enums\Chart as ChartEnum;
use LaravelEnso\Helpers\Services\Decimals;

class Bubble extends Chart
Expand All @@ -22,7 +22,7 @@ public function __construct()
$this->autoRadius = true;
$this->radiusLimit = 25;

$this->type(Charts::Bubble)
$this->type(ChartEnum::Bubble->value)
->ratio(1.6);
}

Expand Down
4 changes: 2 additions & 2 deletions src/Factories/Doughnut.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

namespace LaravelEnso\Charts\Factories;

use LaravelEnso\Charts\Enums\Charts;
use LaravelEnso\Charts\Enums\Chart as ChartEnum;

class Doughnut extends Circles
{
public function __construct()
{
parent::__construct();

$this->type(Charts::Doughnut)
$this->type(ChartEnum::Doughnut->value)
->ratio(1);
}
}
4 changes: 2 additions & 2 deletions src/Factories/Line.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace LaravelEnso\Charts\Factories;

use Illuminate\Support\Collection;
use LaravelEnso\Charts\Enums\Charts;
use LaravelEnso\Charts\Enums\Chart as ChartEnum;

class Line extends Chart
{
Expand All @@ -15,7 +15,7 @@ public function __construct()

$this->fill = false;

$this->type(Charts::Line)
$this->type(ChartEnum::Line->value)
->ratio(1.6);
}

Expand Down
4 changes: 2 additions & 2 deletions src/Factories/Pie.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

namespace LaravelEnso\Charts\Factories;

use LaravelEnso\Charts\Enums\Charts;
use LaravelEnso\Charts\Enums\Chart as ChartEnum;

class Pie extends Circles
{
public function __construct()
{
parent::__construct();

$this->type(Charts::Pie)
$this->type(ChartEnum::Pie->value)
->ratio(1);
}
}
4 changes: 2 additions & 2 deletions src/Factories/Polar.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

namespace LaravelEnso\Charts\Factories;

use LaravelEnso\Charts\Enums\Charts;
use LaravelEnso\Charts\Enums\Chart as ChartEnum;

class Polar extends Circles
{
public function __construct()
{
parent::__construct();

$this->type(Charts::PolarArea)
$this->type(ChartEnum::PolarArea->value)
->ratio(1);
}
}
4 changes: 2 additions & 2 deletions src/Factories/Radar.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
namespace LaravelEnso\Charts\Factories;

use Illuminate\Support\Collection;
use LaravelEnso\Charts\Enums\Charts;
use LaravelEnso\Charts\Enums\Chart as ChartEnum;

class Radar extends Chart
{
public function __construct()
{
parent::__construct();

$this->type(Charts::Radar)
$this->type(ChartEnum::Radar->value)
->ratio(1);
}

Expand Down