[13.x] Generate plural morph pivot table name #56832
Merged
+8
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt to fix #43800. In the documentation, polymorphic relationships use pivot tables with plural names. However, the
Pivot
model class does not take that into account when automatically generating the table name since standard (non-polymorphic) pivot tables use singular names and theMorphPivot
class extends from it.The tests never properly covered this case since all usages of the
MorphPivot
class set the table name explicitly since it does not match the class names.This is a breaking change because existing code could be depending on the morph pivot table name being singular in order to work around the bug.