-
Notifications
You must be signed in to change notification settings - Fork 205
Add Two Factor Authentication for Vue Starter Kit #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…etter reusability and cleanup (#148)
…e component and simplify implementation logic (#149)
…ts and improve conditional rendering
…imize TwoFactor UI components
…d improve UI logic consistency
…nhance state management, and optimize TwoFactor UI components
…improve recovery codes visibility toggle, and standardize spacing
…ty in session handling
…, and standardize naming conventions
…s with Inertia assertions, and improve naming consistency
…refine recovery codes handling
…refine recovery codes handling
…actor component to simplify structure
…to simplify structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pushpak1300 why are these migrations not in the original create_users_table
migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, is there a reason you made this migration separate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two-factor authentication can be made an optional feature. Instead of modifying the file, they can simply revert the migration and delete it.
…ks, improved UI spacing, and expanded test coverage
…ery codes handling, and standardize UI consistency
… simplify PinInput structure
…oFactor logic, and enhance PinInput handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass done, let's make these updates and I'll do another round. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, is there a reason you made this migration separate?
This MR adds Two-Factor Authentication (2FA) functionality to the Vue Starter Kit using Laravel Fortify's built-in support for 2FA
🔒 Backend Changes
We are now leveraging Fortify for handling two-factor authentication. Since Fortify provides additional security features out of the box, this MR also replaces our custom implementation of the password confirmation page with Fortify’s native confirm password functionality.
🖥️ Frontend/UI Updates
The UI has been updated to handle all the two-factor settings based on Fortify's configuration. The following Fortify features are enabled:
📹 Demo
Here is the video demo for this feature:
Two Factor with Confirmation setting enabled.
https://www.loom.com/share/89132b7009844daab519008fa8100952?sid=3492a032-5944-47cf-9286-9ed2879c4808
Two Factor without Confirmation setting enabled.
https://www.loom.com/share/a68731fc85ae4f52831ff95a63d4004f?sid=37715df6-fa21-459d-b88b-c52dd4e638ea
Two Factor without Password Confirmation
https://www.loom.com/share/4b808f14e80043e9ab55258b08c7d2b6?sid=35bfdc88-4c80-45f9-995a-fbca972bccad