feat: improve types and deprecate old API #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
geclos
commented
Sep 29, 2025
geclos
commented
- Deprecates APIs v1 and v2
- Improves type checking performance through several optimizations
- Removes compiler packages
- Removes static type generation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
geclos
force-pushed
the
feat/remove_barrel_files
branch
from
8397f2e to
a9e5067
Compare
andresgutgon
reviewed
Oct 1, 2025
andresgutgon
reviewed
Oct 1, 2025
andresgutgon
reviewed
Oct 1, 2025
| @@ -475,7 +469,7 @@ export type PromptSource = EvaluationV2 | DocumentRunPromptSource | |||
| export type LatitudeToolDefinition = { | |||
| name: LatitudeTool | |||
| internalName: LatitudeToolInternalName | |||
| definition: (context?: TelemetryContext) => Tool | |||
| definition: (context?: any) => Tool | |||
There was a problem hiding this comment.
Is this necessary? We still need to import telemetry in core no?
There was a problem hiding this comment.
better to limit telemetry import as much as possible so that next can tree shake
andresgutgon
reviewed
Oct 1, 2025
|
In - "@google-cloud/aiplatform": "^3.35.0",
- "llamaindex": "^0.8.37",It's ok? I comment here because files section on Github do not load I guess is because we don't care about the types for this instrumentations no? |
index 8104bb2c7..253c55c24 100644
--- a/packages/core/tsconfig.json
+++ b/packages/core/tsconfig.json
@@ -5,5 +5,16 @@
"jsx": "preserve"
},
"include": ["src", "drizzle.config.ts"],
- "exclude": ["node_modules", "dist"]
+ "exclude": [
+ "**/*.js",
+ "**/*.spec.*",
+ "**/*.test.*",
+ "dist",
+ "node_modules",
+ "src/**/__tests__/**",
+ "src/**/testHelper.ts",
+ "src/**/testHelpers/**",
+ "src/schema/schema.ts",
+ "src/tests/**"
+ ]
}We lost typescript in tests this way no? |
it's ok yes these 2 were big culprits of performance issues in telemetry package |
Yes, tradeoff between performance and type checking scope |
andresgutgon
force-pushed
the
feat/remove_barrel_files
branch
from
a9e5067 to
210b770
Compare
andresgutgon
force-pushed
the
feat/remove_barrel_files
branch
2 times, most recently
from
b0d9e9f to
b7c2831
Compare
- Deprecates APIs v1 and v2 - Improves type checking performance through several optimizations - Removes compiler packages - Removes static type generation
geclos
force-pushed
the
feat/remove_barrel_files
branch
from
669146d to
6ea5fb8
Compare
geclos
force-pushed
the
feat/remove_barrel_files
branch
from
6ea5fb8 to
2ed878b
Compare
andresgutgon
approved these changes
Oct 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.