Skip to content

Conversation

rushilsrivastava
Copy link

@rushilsrivastava rushilsrivastava commented Nov 26, 2024

The current implementation of _ASGIMiddlewareResponder buffers the http.response.start message and delays sending it until the first http.response.body message. While this ordering adheres to the ASGI specification, it breaks streaming responses because streaming responses expect http.response.start, to be sent immediately, followed by body chunks incrementally.

I am not sure if there is a good reason to delay headers as you can send them immediately

@bharathvaj-ganesan
Copy link

I'm facing this issue as well. +1

@laurentS Thanks for building such a library. Very helpful. Can this support be considered because for a Async FastAPI service which streams response this is a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants