Buttons / links on account created / deleted pages changes #5368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisRob
requested changes
Sep 8, 2025
There was a problem hiding this comment.
Thanks @yeshwanth235 for your continued contributions.
All looks good - just one note regarding the choice of a design system component.
| appearance="raised-button" | ||
| :primary="true" | ||
| :text="$tr('backToLogin')" | ||
| @click="$router.push({ name: 'Main' })" |
There was a problem hiding this comment.
Since the only purpose of clicking the button is to redirect, KRouterLink would be better fit
There was a problem hiding this comment.
You can also think about it from the perspective of semantic and accessible HTML markup - KRouterLink will render as <a> which is more appropriate here (compared to <button>).
|
Hi @yeshwanth235, I will be on vacation until September 22, so unless someone else merges your PR after you've resolved the feedback, I will get back to you as soon as I'm back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated VBtn to Kbutton in Account Delete and Account Created pages
References
5353
Reviewer guidance
Test Kbuttons in Account Deleted and Account created pages.