-
Notifications
You must be signed in to change notification settings - Fork 428
fix VAE tiling for Qwen Image #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Did you try if this works with wan? |
It will not trigger with WAN in it's current state, because |
@wbruna i can confirm it works for qwen image, and there's no regression with WAN (still works fine with no tiling) |
It was failing simply because the split+merge assumed a specific tensor shape (and blowing up deep inside ggml because the wrong shapes triggered a division by zero). But for Wan, I'm sure leejet would have spotted this bug if it was just a matter of fixing the dimensions... Feel free to try it, though; I'm not sure I have either hardware or patience enough for that 😅. |
Not enough for img2img, unfortunately; any encode tiling triggers an assertion:
Edit: fixed it, but needed an explicit test for Qwen Image. |
Intended for #851 ,
but works fine on current master. Edit: encoding path fix applied on top ofqwen_image
.