Skip to content

Conversation

wbruna
Copy link
Contributor

@wbruna wbruna commented Oct 4, 2025

Intended for #851 , but works fine on current master. Edit: encoding path fix applied on top of qwen_image.

@Green-Sky
Copy link
Contributor

Did you try if this works with wan?

@LostRuins
Copy link
Contributor

It will not trigger with WAN in it's current state, because encode_video will be true, so it will never enter the vae tiling codepath

wbruna added a commit to wbruna/llama.cpp that referenced this pull request Oct 4, 2025
@LostRuins
Copy link
Contributor

@wbruna i can confirm it works for qwen image, and there's no regression with WAN (still works fine with no tiling)

@wbruna
Copy link
Contributor Author

wbruna commented Oct 4, 2025

It was failing simply because the split+merge assumed a specific tensor shape (and blowing up deep inside ggml because the wrong shapes triggered a division by zero). But for Wan, I'm sure leejet would have spotted this bug if it was just a matter of fixing the dimensions... Feel free to try it, though; I'm not sure I have either hardware or patience enough for that 😅.

@wbruna
Copy link
Contributor Author

wbruna commented Oct 9, 2025

Not enough for img2img, unfortunately; any encode tiling triggers an assertion:

ggml/src/ggml-backend.cpp:300: GGML_ASSERT(offset + size <= ggml_nbytes(tensor) && "tensor read out of bounds") failed

Edit: fixed it, but needed an explicit test for Qwen Image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants