This repository was archived by the owner on Nov 22, 2023. It is now read-only.
Lab 4 #6
Open
Lab 4 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lab 4 felishtan
igor-leshkevych
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
@JohnSteck9 @maksymbudzin well done, everything works and all the requirements are met.
10/10 for both of you.
| const BottomNavigationBarThemeData(selectedItemColor: Colors.white), | ||
| ); | ||
|
|
||
| ThemeData secondTheme = ThemeData( |
| ThemeData get currentTheme => _currentTheme; | ||
|
|
||
| void toggleTheme() { | ||
| _currentTheme = _currentTheme == mainTheme ? secondTheme : mainTheme; |
There was a problem hiding this comment.
you can use something like this instead:
final themes = [primaryTheme, secondaryTheme];
int currentTheme = 0;
Theme get currentTheme => themes[currentTheme];
void toggle() {
currentTheme = (currentTheme + 1) % themes.length;
}
this will allow you to cycle through themes, and adding new themes to themes array without changing a code inside your toggle
|
|
||
| void generateRandomImage() { | ||
| var random = new Random(); | ||
| int min = 1; |
There was a problem hiding this comment.
too many variables, just use
var randomIndex = 1 + Random().nextInt(63707306);
| } | ||
|
|
||
| class MyApp extends StatelessWidget { | ||
| const MyApp({Key? key}) : super(key: key); | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| // var incrementValue = context.watch<Increment>().count; |
There was a problem hiding this comment.
dont leave commented blocks of code
| } | ||
|
|
||
| class LibraryState extends State<LibraryTab> { | ||
| late String temp; |
There was a problem hiding this comment.
just use
String newPlaylist = '';
| void initState() { | ||
| super.initState(); | ||
|
|
||
| playList.addAll(['maks_playlist', 'vika_playlist', 'mykhailo_playlist']); |
There was a problem hiding this comment.
just use
List playList = ['maks_playlist', 'vika_playlist', 'mykhailo_playlist'];
when declaring the field
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Maxim's local state:
This state allows us to add and remove our custom playlists on the library screen by tap on + New playlist
Added Mykhailo's local state:
This state allows us to increase the number of views by tap on them
Added Maxim's global state:
This global state allows us to change the theme of the application on the light and on the dark by tap on the icon in the app bar
Added Mykhailo's global state:
This global state allows us to change the user icon to a random icon from the git hub by tap on the user icon in the user screen