Add ActionForm's submit handler last #4131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures on:submit handlers added by users of ActionFrom run before the form is submitted and can use prevent_default to cancel the submit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delays adding
ActionForm's on:submit handler so on:submit handlers added by users of ActionFrom run before the form is submitted and can use prevent_default to cancel the submit.This is a potential alternative to #4130 but instead of delaying running the submit, it delays adding the submit.
Drawback to be aware of with this fix is if a user adds a submit handler using code at runtime it will still run after the ActionForm's on:submit. The problem with #4130 was is wasn't working with browser dialogs (e.g.
window().confirm_with_message("hello world")) which is commonly used with on:submit events.