Skip to content

Actually validate grant code #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Actually validate grant code #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion flask_oauthlib/provider/oauth2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,6 +833,9 @@ def validate_code(self, client_id, code, client, request, *args, **kwargs):
datetime.datetime.utcnow() > grant.expires:
log.debug('Grant is expired.')
return False
if grant.code != code:
log.debug('Grant is invalid.')
return False

request.state = kwargs.get('state')
request.user = grant.user
Expand All @@ -859,7 +862,7 @@ def validate_grant_type(self, client_id, grant_type, client, request,
'authorization_code', 'password',
'client_credentials', 'refresh_token',
)

# Grant type is allowed if it is part of the 'allowed_grant_types'
# of the selected client or if it is one of the default grant types
if hasattr(client, 'allowed_grant_types'):
Expand Down