-
Notifications
You must be signed in to change notification settings - Fork 140
fix: update packages #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: testnet
Are you sure you want to change the base?
fix: update packages #1187
Conversation
WalkthroughUpdated package.json dependency versions across runtime and dev tooling, removed @anima-protocol/personhood-sdk-react, and added twitter-api-sdk. Multiple major version bumps for Next.js, React, StarkNet ecosystem, and related libraries. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (3)
package.json (3)
35-41: Declare required Node.js engine for Next 14/React 18.3.Add engines to prevent accidental installs on unsupported Node versions (Next 14 requires >=18.17; many toolchains now target Node 20).
"private": true, + "engines": { + "node": ">=18.17.0" + },If your deploy target already uses Node 20, prefer ">=20.0.0".
58-59: Update React type packages to match React 18.3.These are pinned to older 18.0.x; with react/react-dom 18.3.1 you may hit type mismatches.
- "@types/react": "18.0.17", - "@types/react-dom": "18.0.6", + "@types/react": "^18.3.5", + "@types/react-dom": "^18.3.0",
6-11: Optional: expand lint coverage to .js/.cjs/.mjs.If the repo still has JS files, the current glob misses them.
- "lint": "eslint '**/*.{jsx,ts,tsx}'", + "lint": "eslint '**/*.{js,jsx,ts,tsx,cjs,mjs}'",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (4)
package.json (4)
13-24: Audit breaking changes across StarkNet stack upgrades.You bumped get-starknet/core, @starknet-react/* to 5.x, starknet 7.x, and starknetkit 3.x. These contain breaking API/behavior changes (wallet detection, provider/account shapes, connectors).
- Re-run wallet connect, network switch, and account deployment flows locally.
- Check for Node polyfill needs in the browser bundle (Buffer/crypto) introduced by web3 libs.
I can help generate a migration checklist if desired.
Also applies to: 44-47
29-29: dotenv usage is correctly scoped
dotenv is only required intests/utils/apiWrappers/identity.test.ts(a Node context), with no imports in client modules. No changes needed.
48-48: Verify no client-side imports of twitter-api-sdk. A scan returned noimportorrequirereferences for this package—manually confirm it’s only used in API routes or server components to avoid bundling it into client-side code.
51-67: No updates required for @typescript-eslint or Jest setup. The installed @typescript-eslint/parser & plugin v5.62.0 both support TypeScript <6.0.0 (so TS 5.9 is within range) and ESLint ^8.57.1 satisfies their peer-dependency. babel-jest is used (no ts-jest present), and eslint-config-next v14 supports TS 5.9.
| "dependencies": { | ||
| "@anima-protocol/personhood-sdk-react": "^0.4.4", | ||
| "@avnu/gasless-sdk": "^0.1.6", | ||
| "@emotion/react": "^11.10.0", | ||
| "@emotion/styled": "^11.10.0", | ||
| "@mui/icons-material": "^5.8.4", | ||
| "@mui/material": "^5.10.1", | ||
| "@nimiq/style": "^0.8.4", | ||
| "@starknet-io/get-starknet": "^4.0.6", | ||
| "@starknet-io/get-starknet-core": "^4.0.6", | ||
| "@avnu/gasless-sdk": "^0.1.8", | ||
| "@emotion/react": "^11.14.0", | ||
| "@emotion/styled": "^11.14.1", | ||
| "@mui/icons-material": "^5.18.0", | ||
| "@mui/material": "^5.18.0", | ||
| "@nimiq/style": "^0.8.5", | ||
| "@starknet-io/get-starknet": "^4.0.7", | ||
| "@starknet-io/get-starknet-core": "^4.0.7", | ||
| "@starknet-io/types-js": "^0.7.10", | ||
| "@starknet-react/chains": "^3.1.0", | ||
| "@starknet-react/core": "^3.7.4", | ||
| "@vercel/analytics": "^0.1.5", | ||
| "@walnuthq/sdk": "^1.1.10", | ||
| "axios": "^1.4.0", | ||
| "@starknet-react/chains": "^5.0.1", | ||
| "@starknet-react/core": "^5.0.1", | ||
| "@vercel/analytics": "^0.1.11", | ||
| "@walnuthq/sdk": "^1.1.11", | ||
| "axios": "^1.11.0", | ||
| "big.js": "^6.2.2", | ||
| "bn.js": "^5.2.1", | ||
| "dotenv": "^16.3.1", | ||
| "eslint-config-next": "^13.4.7", | ||
| "ethers": "^6.12.1", | ||
| "jotai": "^2.5.0", | ||
| "lottie-react": "^2.4.0", | ||
| "mongodb": "^4.12.1", | ||
| "next": "^14.2.3", | ||
| "next-axiom": "^1.9.1", | ||
| "nextjs-cors": "^2.1.2", | ||
| "posthog-js": "^1.68.4", | ||
| "qs": "^6.12.1", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-icons": "^4.4.0", | ||
| "bn.js": "^5.2.2", | ||
| "dotenv": "^16.6.1", | ||
| "eslint-config-next": "^13.5.11", | ||
| "ethers": "^6.15.0", | ||
| "jotai": "^2.13.1", | ||
| "lottie-react": "^2.4.1", | ||
| "mongodb": "^4.17.2", | ||
| "next": "^14.2.32", | ||
| "next-axiom": "^1.9.2", | ||
| "nextjs-cors": "^2.2.0", | ||
| "posthog-js": "^1.261.4", | ||
| "qs": "^6.14.0", | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1", | ||
| "react-icons": "^4.12.0", | ||
| "react-loader-spinner": "5.4.5", | ||
| "starknet": "^6.24.1", | ||
| "starknet": "^7.6.4", | ||
| "starknetid.js": "4.0.1", | ||
| "starknetkit": "^2.12.1", | ||
| "tldts": "^6.1.20", | ||
| "starknetkit": "^3.0.3", | ||
| "tldts": "^6.1.86", | ||
| "twitter-api-sdk": "^1.2.1" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Confirm removal of @anima-protocol/personhood-sdk-react across codebase.
Double-check there are no lingering imports to avoid runtime build errors.
🏁 Script executed:
#!/bin/bash
rg -n "@anima-protocol/personhood-sdk-react" -C2Length of output: 1891
Remove lingering @anima-protocol/personhood-sdk-react references
- Uninstall the package (
npm uninstall @anima-protocol/personhood-sdk-react), remove it from package.json, and regenerate your lockfile to clear it from package-lock.json. - In components/identities/actions/clickable/clickablePersonhoodIcon.tsx, delete:
import "@anima-protocol/personhood-sdk-react/style.css"; import { Personhood, StarknetSignature } from "@anima-protocol/personhood-sdk-react";
🤖 Prompt for AI Agents
In package.json (lines 12-49) and
components/identities/actions/clickable/clickablePersonhoodIcon.tsx, remove all
traces of @anima-protocol/personhood-sdk-react: run npm uninstall
@anima-protocol/personhood-sdk-react (or yarn remove), remove its dependency
entry from package.json if present, run npm install to regenerate
package-lock.json, and in the TSX file delete the two import lines importing the
package and its style; then run a clean build to ensure no residual references
remain.
| "react-icons": "^4.4.0", | ||
| "bn.js": "^5.2.2", | ||
| "dotenv": "^16.6.1", | ||
| "eslint-config-next": "^13.5.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Align eslint-config-next with Next 14.
Version 13.x of eslint-config-next can conflict with Next 14 rules/peers. Bump to the 14.x line.
- "eslint-config-next": "^13.5.11",
+ "eslint-config-next": "^14.2.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "eslint-config-next": "^13.5.11", | |
| "eslint-config-next": "^14.2.0", |
🤖 Prompt for AI Agents
In package.json around line 30, the eslint-config-next dependency is pinned to
the 13.x line; update the version string to the 14.x line (e.g. replace
"eslint-config-next": "^13.5.11" with "eslint-config-next": "^14.0.0") and then
run your package manager (npm install or yarn install) to refresh lockfile and
node_modules so peer rules align with Next 14.
Summary by CodeRabbit
Chores
Bug Fixes
Performance