Skip to content

Conversation

@lgallard
Copy link
Owner

@lgallard lgallard commented Jul 13, 2025

Summary

This PR addresses issues #160 and #162 by fixing validation errors in the cost_optimized_backup example that were discovered during testing.

Issues Resolved

Additional Fix Applied

Fixed incorrect module output references in examples/cost_optimized_backup/outputs.tf that were causing terraform validate failures:

Changes Made:

  • backup_vault_arnvault_arn
  • backup_vault_idvault_id
  • backup_plan_arns[key]plans[key].arn
  • backup_plan_ids[key]plans[key].id
  • backup_role_arnplan_role
  • ✅ Removed unsupported backup_selection_ids output

Validation Results

Both examples now pass validation:

# cross_region_backup
terraform validate
✅ Success! The configuration is valid.

# cost_optimized_backup  
terraform validate
✅ Success! The configuration is valid.

Test Plan

  • Validated cross_region_backup example passes terraform validate
  • Validated cost_optimized_backup example passes terraform validate
  • Ensured all output references match actual module outputs
  • Verified terraform fmt passes on all files
  • Confirmed no breaking changes to module interface

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

🤖 Generated with Claude Code

Fixes issue where cost_optimized_backup example outputs.tf referenced
non-existent module outputs, causing terraform validate failures.

Changes:
- Change backup_vault_arn → vault_arn
- Change backup_vault_id → vault_id
- Change backup_plan_arns[key] → plans[key].arn
- Change backup_plan_ids[key] → plans[key].id
- Change backup_role_arn → plan_role
- Remove unsupported backup_selection_ids output

Resolves validation errors and ensures example works correctly.

Closes #160 - notifications parameter was already removed from cross_region_backup
Closes #162 - invalid cold_storage_after configuration was already fixed

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@lgallard
Copy link
Owner Author

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

@lgallard lgallard changed the title fix: Resolve issues #160 and #162 - Example validation fixes fix:Example validation fixes Jul 13, 2025
@lgallard lgallard merged commit 28e24cb into master Jul 13, 2025
37 checks passed
@lgallard lgallard deleted the fix/issues-160-162-example-fixes branch July 13, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants