Constify math descriptors #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
force-pushed
the
constify-math
branch
2 times, most recently
from
786d146 to
fd73856
Compare
sjaeckel
force-pushed
the
constify-math
branch
from
fd73856 to
00b9c91
Compare
Collaborator
Author
|
This looks ready to merge |
This includes amending the documentation in doc/crypt.tex This also includes removing unnecessary casts in src/math/*.c
…ased) TFM is notorious for not having a properly constified API. This is to appear in its next release, which is tentatively set to 0.14.0.
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
sjaeckel
force-pushed
the
constify-math
branch
from
00b9c91 to
1d07689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of all, this adds proper constification to
ltc_math_descriptor,the rest is suffering the consequences.
For TomsFastMath specifically, we add unconsting casts so LTM can be compiled
to TFM versions before it gets properly constified. This is done through a
version checking helper macro that is added in libtom/tomsfastmath#36.
Note that the current TFM release isn't properly constified, but hopefully,
0.14.0 will be.