Align demo/CMakeLists.txt a bit more with with makefile_include.mk #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I have some more changes in this regard locally, I'll integrated what you did here next week and push to this PR if that's OK for you!? |
levitte
force-pushed
the
cmake-all-demos
branch
from
d49e101 to
32509ed
Compare
Collaborator
Author
|
I just rebased it on top of a fresh Either way, if you have more updates, it's OK to integrate them with this patch |
Now, they build the same executables.
sjaeckel
force-pushed
the
cmake-all-demos
branch
2 times, most recently
from
32509ed to
6659f36
Compare
Merged
Collaborator
Author
|
Closing in favor of #677, where this patch is incorporated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, they build the same executables.