Skip to content

tests/lapi: package tests #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

tests/lapi: package tests #134

merged 1 commit into from
Jul 28, 2025

Conversation

ligurio
Copy link
Owner

@ligurio ligurio commented May 30, 2025

No description provided.

@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-package branch 3 times, most recently from 0ed293c to 1fdabf7 Compare June 2, 2025 09:34
@ligurio ligurio requested a review from Buristan July 14, 2025 09:39
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sergey!
Thanks for the patch!
Please consider my comments below.

@Buristan Buristan assigned ligurio and unassigned Buristan Jul 17, 2025
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-package branch 2 times, most recently from 37550d0 to bea61d5 Compare July 22, 2025 12:30
@ligurio ligurio requested a review from Buristan July 22, 2025 12:33
@ligurio ligurio assigned Buristan and unassigned ligurio Jul 22, 2025
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-package branch from bea61d5 to df93991 Compare July 22, 2025 14:52
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sergey!
Thanks for the fixes!
LGTM, after fixing the last discussion above.

@Buristan Buristan assigned ligurio and unassigned Buristan Jul 24, 2025
The patch adds a test for the `require()` function. Note, the test
is disabled by default.
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-package branch from df93991 to a6451b5 Compare July 24, 2025 13:39
@ligurio ligurio requested a review from Buristan July 24, 2025 14:50
@ligurio ligurio merged commit ab5eb92 into master Jul 28, 2025
12 checks passed
@ligurio ligurio deleted the ligurio/gh-xxxx-lapi-package branch July 28, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants