Implemented Private Image Sharing features

[ezilber-akamai]

📝 Description

Implements support for Private Image Sharing.

✔️ How to Test

The following test steps assume you have pulled down this PR locally. Note that several integration tests will be skipped unless you set the LINODE_PRODUCER_TOKEN and LINODE_CONSUMER_TOKEN environment variables (pointing at two different accounts), as some features require multiple accounts to test.

NOTE: There are some known filtering issues in the API that will cause test failures for the following tests:

• make test-int PKG_NAME="images" TEST_CASE="TestAccDataSourceImages_basic_smoke"
• make test-int PKG_NAME="producerimagesharegroupmembers" TEST_CASE="TestAccDataSourceImageShareGroupMembers_basic"

Unit Testing

• make test-unit

Integration Testing

• make test-int PKG_NAME="image" TEST_CASE="TestAccDataSourceImage_basic"
• make test-int PKG_NAME="image" TEST_CASE="TestAccImage_basic"
• make test-int PKG_NAME="images" TEST_CASE="TestAccDataSourceImages_basic_smoke"
• make test-int PKG_NAME="producerimagesharegroup" TEST_CASE="TestAccDataSourceImageShareGroup_basic"
• make test-int PKG_NAME="producerimagesharegroup" TEST_CASE="TestAccResourceImageShareGroup_basic"
• make test-int PKG_NAME="producerimagesharegroup" TEST_CASE="TestAccResourceImageShareGroup_updates"
• make test-int PKG_NAME="producerimagesharegroups" TEST_CASE="TestAccDataSourceImageShareGroups_basic"
• make test-int PKG_NAME="producerimagesharegroupimageshares" TEST_CASE="TestAccDataSourceImageShareGroupImageShares_basic"
• make test-int PKG_NAME="consumerimagesharegrouptoken" TEST_CASE="TestAccResourceImageShareGroupToken_basic"
• make test-int PKG_NAME="producerimagesharegroupmember" TEST_CASE="TestAccResourceImageShareGroupMember_basic"
• make test-int PKG_NAME="producerimagesharegroupmember" TEST_CASE="TestAccDataSourceImageShareGroupMember_basic"
• make test-int PKG_NAME="producerimagesharegroupmembers" TEST_CASE="TestAccDataSourceImageShareGroupMembers_basic"
• make test-int PKG_NAME="consumerimagesharegrouptoken" TEST_CASE="TestAccDataSourceImageShareGroupToken_basic"
• make test-int PKG_NAME="consumerimagesharegrouptokens" TEST_CASE="TestAccDataSourceImageShareGroupTokens_basic"
• make test-int PKG_NAME="consumerimagesharegroup" TEST_CASE="TestAccDataSourceConsumerImageShareGroup_basic"
• make test-int PKG_NAME="consumerimagesharegroupimageshares" TEST_CASE="TestAccDataSourceImageShareGroupImageShares_basic"

Manual Testing

Export the following environment variables (you will need two separate accounts to test all the features in this PR):

export TF_VAR_producer_token=$LINODE_PRODUCER_TOKEN
export TF_VAR_consumer_token=$LINODE_CONSUMER_TOKEN

To simplify what will already be a long and complex TF config, I recommend creating a small Linode Instance and one or two Images pointing at it manually in CM. You will then be able to simple use the Image's IDs in the config, which should speed up how quickly the config runs. This should be done on the account that will serve as the Producer.

When the Linode Instance and Images have been created, run the following config:

variable "producer_token" {
  description = "API token for the producer account"
  type        = string
}

variable "consumer_token" {
  description = "API token for the consumer account"
  type        = string
}

provider "linode" {
  alias = "producer"
  token = var.producer_token
  api_version = "v4beta"
}

provider "linode" {
  alias = "consumer"
  token = var.consumer_token
  api_version = "v4beta"
}

# Create the Share Group on the Producer account
resource "linode_producer_image_share_group" "sharegroup" {
  provider    = linode.producer
  label  = "test-label"
  description = "Example description."
  images = [
    {
        id = <id-of-image>
        description = "Image description."
        label = "image-label"
    },
}

# Create the Share Group Token on the Consumer account
resource "linode_consumer_image_share_group_token" "token" {
  provider                 = linode.consumer
  depends_on               = [linode_producer_image_share_group.sharegroup]
  valid_for_sharegroup_uuid = linode_producer_image_share_group.sharegroup.uuid
}

# Create the Share Group Member on the Producer account
resource "linode_producer_image_share_group_member" "member" {
  provider        = linode.producer
  depends_on      = [linode_consumer_image_share_group_token.token]
  sharegroup_id   = linode_producer_image_share_group.sharegroup.id
  token  = linode_consumer_image_share_group_token.token.token
  label = "test-member"
}

The config above will allow you to create/update the three new resources added in this PR. There are also several datasources that can be used to view data associated with the resources created above.

[Copilot]

Pull Request Overview

This PR implements comprehensive support for private image sharing features, including new resources and data sources for producer image share groups, image share group members, consumer image share group tokens, and image shares. Additionally, it adds support for Linode Interfaces, VPC IPv6 functionality, network helper configuration, and enhanced object storage handling.

Key changes include:

• Addition of private image sharing resources and data sources with proper testing and templates
• Implementation of Linode Interface resource with support for public, VLAN, and VPC interface types
• Enhancement of VPC and VPC subnet resources to support IPv6 configuration
• Improvements to object storage temporary key handling for different endpoint types

Reviewed Changes

Copilot reviewed 227 out of 228 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
linode/producerimagesharegroup/	New producer image share group resource and data source implementation
linode/producerimagesharegroupmembers/	Data source for listing image share group members
linode/producerimagesharegroupmember/	Resource and data source for managing individual members
linode/producerimagesharegroupimageshares/	Data source for listing image shares within share groups
linode/consumerimagesharegrouptoken/	Consumer-side token management (referenced but not in diff)
linode/linodeinterface/	Complete implementation of Linode Interface resource
linode/vpcsubnet/	Enhanced VPC subnet support with IPv6 validation
linode/vpc/	Enhanced VPC resource with IPv6 validation
linode/instance/	Added interface_generation and network_helper support
linode/obj/	Improved object storage key handling for different endpoint types
linode/networkingip/	Added interface_id field to networking IP data sources

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 227 out of 228 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[lgarber-akamai]

Looks great and all tests are passing on my end (- expected failures). Nice work!

[yec-akamai]

Test passed as expected! Just some small suggestions: