Resolve database pending_updates duplicates bug; refactor database schema & model sharing #2166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
added
improvement
lgarber-akamai
requested review from
ezilber-akamai and
yec-akamai
and removed request for
a team,
ezilber-akamai and
yec-akamai
lgarber-akamai
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR resolves a bug where duplicate entries appeared in the pending_updates field of managed database resources and refactors the database-related code by centralizing shared functionality into a new databaseshared package.
- Implements deduplication logic for pending updates using a new
FrameworkDropDuplicatesIterhelper function - Extracts common database models, schema attributes, and utility functions into a shared
linode/helper/databasesharedpackage - Adds comprehensive test coverage with HTTP client modification support to verify the deduplication fix
Reviewed Changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| linode/helper/http.go | Adds HTTPClientModifier type definition for modifying HTTP clients |
| linode/helper/framework_util.go | Adds FrameworkDropDuplicatesIter function for deduplicating iterator values |
| linode/helper/databaseshared/*.go | New package containing shared database models, schemas, and utilities extracted from individual database modules |
| linode/helper/database.go | Removed (functionality moved to databaseshared package) |
| linode/framework_provider_config.go | Adds support for applying HTTP client modifiers during client initialization |
| linode/databases/*.go | Updates to use shared database models from databaseshared package |
| linode/database*/*.go | Refactored to use shared functionality from databaseshared package instead of duplicated code |
| linode/acceptance/*.go | Adds test infrastructure for HTTP response overrides and database-specific test helpers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lgarber-akamai
force-pushed
the
fix/database-pending-updates-set
branch
from
bf00427 to
dbd49c2
Compare
lgarber-akamai
added
the
do-not-merge
…hema & model sharing
lgarber-akamai
force-pushed
the
fix/database-pending-updates-set
branch
from
35faf37 to
fb585e1
Compare
lgarber-akamai
removed
the
do-not-merge
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 40 out of 40 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lgarber-akamai
requested review from
a team and
vshanthe
and removed request for
a team
lgarber-akamai
requested review from
a team,
Copilot,
ezilber-akamai,
yec-akamai and
zliang-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 40 out of 40 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ezilber-akamai
approved these changes
Nov 14, 2025
Contributor
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
This is much cleaner! Tests passed locally
zliang-akamai
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request resolves an issue that prevents the
pending_updatesfield from being properly populated. This is an extension of the fix from #2162.Additionally, this pull request consolidates shared database schema and model logic into a
database_sharedhelper package, which significantly reduces code redundancy.Depends on #2165
✔️ How to Test
The following test steps assume you have pulled down this PR locally.
Integration Testing
Manual Testing
TODO