cargo deny: use -only and -or-later suffixes for GPL licenses #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I get weekly mails about the failing tests. And I can not merge here without approval. |
SmithChart
approved these changes
Aug 22, 2025
|
Can you rebase so we see a successful build before the merge? |
The cargo deny command has recently learned these suffixes,
resulting in our current license allowances no longer matching:
error[rejected]: failed to satisfy license requirements
┌─ /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libsystemd-sys-0.9.3/Cargo.toml:22:12
│
22 │ license = "LGPL-2.1-or-later WITH GCC-exception-2.0"
│ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
│ │
│ rejected: license is not explicitly allowed
│
├ LGPL-2.1-or-later - GNU Lesser General Public License v2.1 or later:
├ - OSI approved
├ - FSF Free/Libre
├ - Copyleft
├ libsystemd-sys v0.9.3
└── systemd v0.10.0
└── tacd v0.2.0
warning[license-not-encountered]: license was not encountered
┌─ /home/runner/work/tacd/tacd/deny.toml:38:6
│
38 │ "LGPL-2.1 WITH GCC-exception-2.0",
│ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unmatched license allowance
Use the license names with suffixes.
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
hnez
force-pushed
the
cargo-deny-2025-08-15
branch
from
42e1048 to
0c9fbb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cargo deny command has recently learned these suffixes, resulting in our current license allowances no longer matching:
Use the license names with suffixes.
This fixes half of the build errors in the recent scheduled job run.
The other half is addressed in #98.