[CIR][NFC] Add cir::CallOp method to get called function
#1892
Conversation
tommymcm
requested review from
lanza,
bcardosolopes,
xlauko and
andykaylor
as code owners
| /// If this is a direct call, returns the callee as a `cir::FuncOp` in parent `module`. | ||
| /// Otherwise, returns `null`. | ||
| /// NOTE: This method walks the symbol table. If you are calling this method a lot, | ||
| /// consider using `cir::FuncOp::getDirectCallee(mlir::SymbolTable &)` instead. |
There was a problem hiding this comment.
How would you make such a change? All of the uses in this PR use the other form.
There was a problem hiding this comment.
If you know youre going to query this a lot, you'd run the mlir::SymbolTableAnalysis and use its result for repeated queries.
There was a problem hiding this comment.
Probably not a good use for CIRGen though, given the symbol table is constantly changing
There was a problem hiding this comment.
mlir::SymbolTableAnalysis claims to be good at handling insertions and removals. I looked through CIRGen though and couldn't find anywhere that this API could be used.
There was a problem hiding this comment.
@andykaylor does that answer your question? Or would you prefer me to remove the symbol table methods until we have a user?
tommymcm
force-pushed
the
callop-callee
branch
from
f393a2d to
9d5e477
Compare
|
Rebased after the latest reverts. CI is green |
No description provided.