Skip to content

Conversation

yotto3s
Copy link

@yotto3s yotto3s commented Sep 27, 2025

PR for #1791

@yotto3s yotto3s changed the title Add EhSetjmpOp to CIR dialect [CIR] Add EhSetjmpOp to CIR dialect Sep 27, 2025
@yotto3s yotto3s changed the title [CIR] Add EhSetjmpOp to CIR dialect [CIR] Add EhLongjmpOp to CIR dialect Sep 27, 2025
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nit

Copy link
Collaborator

@xlauko xlauko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % nits

@bcardosolopes
Copy link
Member

I'll merge as soon as the tests pass, thanks!

@bcardosolopes
Copy link
Member

The are failing testcases, you need to work through those and get CI green!

@yotto3s
Copy link
Author

yotto3s commented Oct 4, 2025

Some tests failed due to the change of cast op format in main branch. I rebased and fixed the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants