Skip to content

RuntimeLibcalls: Remove target check for sjlj config #148792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: users/arsenm/runtime-libcalls/move-_stack_chk_fail-tablegen
Choose a base branch
from

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Jul 15, 2025

I'm assuming this was the set of targets that were relevant
for sjlj handling. Just take the raw exception setting instead,
and assume it makes sense for the target.

Copy link
Contributor Author

arsenm commented Jul 15, 2025

@llvmbot
Copy link
Member

llvmbot commented Jul 15, 2025

@llvm/pr-subscribers-tablegen
@llvm/pr-subscribers-llvm-ir

@llvm/pr-subscribers-backend-arm

Author: Matt Arsenault (arsenm)

Changes

I'm assuming this was the set of targets that were relevant
for sjlj handling. Just take the raw exception setting instead,
and assume it makes sense for the target.


Full diff: https://github.com/llvm/llvm-project/pull/148792.diff

1 Files Affected:

  • (modified) llvm/lib/IR/RuntimeLibcalls.cpp (+2-4)
diff --git a/llvm/lib/IR/RuntimeLibcalls.cpp b/llvm/lib/IR/RuntimeLibcalls.cpp
index 12aa9dc8d3943..8a130ccfcb50c 100644
--- a/llvm/lib/IR/RuntimeLibcalls.cpp
+++ b/llvm/lib/IR/RuntimeLibcalls.cpp
@@ -72,10 +72,8 @@ void RuntimeLibcallsInfo::initLibcalls(const Triple &TT,
                                        EABI EABIVersion, StringRef ABIName) {
   setTargetRuntimeLibcallSets(TT, FloatABI);
 
-  if (TT.isX86() || TT.isVE() || TT.isARM() || TT.isThumb()) {
-    if (ExceptionModel == ExceptionHandling::SjLj)
-      setLibcallImpl(RTLIB::UNWIND_RESUME, RTLIB::_Unwind_SjLj_Resume);
-  }
+  if (ExceptionModel == ExceptionHandling::SjLj)
+    setLibcallImpl(RTLIB::UNWIND_RESUME, RTLIB::_Unwind_SjLj_Resume);
 
   if (TT.isARM() || TT.isThumb()) {
     setARMLibcallNames(*this, TT, FloatABI, EABIVersion);

@llvmbot
Copy link
Member

llvmbot commented Jul 15, 2025

@llvm/pr-subscribers-backend-x86

Author: Matt Arsenault (arsenm)

Changes

I'm assuming this was the set of targets that were relevant
for sjlj handling. Just take the raw exception setting instead,
and assume it makes sense for the target.


Full diff: https://github.com/llvm/llvm-project/pull/148792.diff

1 Files Affected:

  • (modified) llvm/lib/IR/RuntimeLibcalls.cpp (+2-4)
diff --git a/llvm/lib/IR/RuntimeLibcalls.cpp b/llvm/lib/IR/RuntimeLibcalls.cpp
index 12aa9dc8d3943..8a130ccfcb50c 100644
--- a/llvm/lib/IR/RuntimeLibcalls.cpp
+++ b/llvm/lib/IR/RuntimeLibcalls.cpp
@@ -72,10 +72,8 @@ void RuntimeLibcallsInfo::initLibcalls(const Triple &TT,
                                        EABI EABIVersion, StringRef ABIName) {
   setTargetRuntimeLibcallSets(TT, FloatABI);
 
-  if (TT.isX86() || TT.isVE() || TT.isARM() || TT.isThumb()) {
-    if (ExceptionModel == ExceptionHandling::SjLj)
-      setLibcallImpl(RTLIB::UNWIND_RESUME, RTLIB::_Unwind_SjLj_Resume);
-  }
+  if (ExceptionModel == ExceptionHandling::SjLj)
+    setLibcallImpl(RTLIB::UNWIND_RESUME, RTLIB::_Unwind_SjLj_Resume);
 
   if (TT.isARM() || TT.isThumb()) {
     setARMLibcallNames(*this, TT, FloatABI, EABIVersion);

@arsenm arsenm force-pushed the users/arsenm/runtime-libcalls/move-_stack_chk_fail-tablegen branch from 4717482 to 407ba2c Compare July 15, 2025 07:22
@arsenm arsenm force-pushed the users/arsenm/runtime-libcalls/remove-target-check-exception-model-sjlj branch from 8e04afa to 3babdff Compare July 15, 2025 07:22
@arsenm arsenm force-pushed the users/arsenm/runtime-libcalls/move-_stack_chk_fail-tablegen branch from 407ba2c to 7bf2a69 Compare July 28, 2025 02:43
@arsenm arsenm force-pushed the users/arsenm/runtime-libcalls/remove-target-check-exception-model-sjlj branch from 3babdff to 48d32f8 Compare July 28, 2025 02:43
I'm assuming this was the set of targets that were relevant
for sjlj handling. Just take the raw exception setting instead,
and assume it makes sense for the target.
@arsenm arsenm force-pushed the users/arsenm/runtime-libcalls/move-_stack_chk_fail-tablegen branch from 7bf2a69 to dfa00ac Compare July 28, 2025 03:05
@arsenm arsenm force-pushed the users/arsenm/runtime-libcalls/remove-target-check-exception-model-sjlj branch from 48d32f8 to 204630d Compare July 28, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants