Skip to content

[PowerPC] Add assembly directives to change endianness #149811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+46 −1
Open

[PowerPC] Add assembly directives to change endianness #149811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion llvm/lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1655,7 +1655,17 @@ bool PPCAsmParser::ParseDirective(AsmToken DirectiveID) {
parseDirectiveTC(isPPC64() ? 8 : 4, DirectiveID);
else if (IDVal == ".machine")
parseDirectiveMachine(DirectiveID.getLoc());
else if (IDVal == ".abiversion")
else if (IDVal == ".big") {
PPCTargetStreamer *TStreamer = static_cast<PPCTargetStreamer *>(
getParser().getStreamer().getTargetStreamer());
if (TStreamer != nullptr)
TStreamer->emitEndianSet(false);
} else if (IDVal == ".little") {
PPCTargetStreamer *TStreamer = static_cast<PPCTargetStreamer *>(
getParser().getStreamer().getTargetStreamer());
if (TStreamer != nullptr)
TStreamer->emitEndianSet(true);
} else if (IDVal == ".abiversion")
parseDirectiveAbiVersion(DirectiveID.getLoc());
else if (IDVal == ".localentry")
parseDirectiveLocalEntry(DirectiveID.getLoc());
Expand Down
2 changes: 2 additions & 0 deletions llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ class PPCMCCodeEmitter : public MCCodeEmitter {
/// Check if Opcode corresponds to a call instruction that should be marked
/// with the NOTOC relocation.
bool isNoTOCCallInstr(const MCInst &MI) const;

void setLittleEndian(bool little_endian) { IsLittleEndian = little_endian; }
};

} // namespace llvm
Expand Down
22 changes: 22 additions & 0 deletions llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCTargetDesc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include "MCTargetDesc/PPCMCAsmInfo.h"
#include "PPCELFStreamer.h"
#include "PPCMCAsmInfo.h"
#include "PPCMCCodeEmitter.h"
#include "PPCTargetStreamer.h"
#include "PPCXCOFFStreamer.h"
#include "TargetInfo/PowerPCTargetInfo.h"
Expand Down Expand Up @@ -246,6 +247,10 @@ class PPCTargetAsmStreamer : public PPCTargetStreamer {
OS << "\t.machine " << CPU << '\n';
}

void emitEndianSet(bool little) override {
OS << (little ? "\t.little\n" : "\t.big\n");
}

void emitAbiVersion(int AbiVersion) override {
OS << "\t.abiversion " << AbiVersion << '\n';
}
Expand Down Expand Up @@ -280,6 +285,13 @@ class PPCTargetELFStreamer : public PPCTargetStreamer {
// limit the parser?
}

void emitEndianSet(bool little) override {
PPCMCCodeEmitter *emitter = static_cast<PPCMCCodeEmitter *>(
getStreamer().getAssembler().getEmitterPtr());
if (emitter != nullptr)
emitter->setLittleEndian(little);
}

void emitAbiVersion(int AbiVersion) override {
ELFObjectWriter &W = getStreamer().getWriter();
unsigned Flags = W.getELFHeaderEFlags();
Expand Down Expand Up @@ -408,6 +420,16 @@ class PPCTargetXCOFFStreamer : public PPCTargetStreamer {
.setCPU(CPU);
}

void emitEndianSet(bool little) override {
MCAssembler *assembler = getStreamer().getAssemblerPtr();
if (assembler == nullptr)
return;
PPCMCCodeEmitter *emitter =
static_cast<PPCMCCodeEmitter *>(assembler->getEmitterPtr());
if (emitter != nullptr)
emitter->setLittleEndian(little);
}

void emitAbiVersion(int AbiVersion) override {
llvm_unreachable("ABI-version pseudo-ops are invalid for XCOFF.");
}
Expand Down
1 change: 1 addition & 0 deletions llvm/lib/Target/PowerPC/MCTargetDesc/PPCTargetStreamer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class PPCTargetStreamer : public MCTargetStreamer {

virtual void emitTCEntry(const MCSymbol &S, PPCMCExpr::Specifier Kind) {}
virtual void emitMachine(StringRef CPU){};
virtual void emitEndianSet(bool little) {};
virtual void emitAbiVersion(int AbiVersion){};
virtual void emitLocalEntry(MCSymbolELF *S, const MCExpr *LocalOffset){};
};
Expand Down
10 changes: 10 additions & 0 deletions llvm/test/MC/PowerPC/endian-directive.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# RUN: llvm-mc -filetype=obj -triple=powerpc-unknown-linux-gnu %s | llvm-readobj -x .text - | FileCheck -check-prefix=CHECK-BE %s
# RUN: llvm-mc -filetype=obj -triple=ppc32le-unknown-linux-gnu %s | llvm-readobj -x .text - | FileCheck -check-prefix=CHECK-LE %s
add %r0, %r1, %r2
.big
add %r0, %r1, %r2
.little
add %r0, %r1, %r2

# CHECK-BE: 0x00000000 7c011214 7c011214 1412017c |...|......|
# CHECK-LE: 0x00000000 1412017c 7c011214 1412017c ...||......|
Loading