-
-
Notifications
You must be signed in to change notification settings - Fork 458
Enhanced chat input #1794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Enhanced chat input #1794
Conversation
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
bugbot run |
if (!autonomousAgentToggle) { | ||
if (vaultToggle) toolCalls.push("@vault"); | ||
if (webToggle) toolCalls.push("@websearch"); | ||
if (webToggle) toolCalls.push("@web-search"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
// Use Range for accurate positioning | ||
const editorWindow = editor._window ?? window; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Plugin Accesses Private Lexical API
The NoteCommandPlugin.tsx
and SlashCommandPlugin.tsx
components access editor._window
, which is a private Lexical property. Relying on this internal API makes the code fragile and susceptible to breaking changes in future Lexical versions.
Additional Locations (1)
@logancyang please hold on bugbot for now. The PR is not done yet |
Enhanced Chat Input with Rich Context Support
Summary
This PR introduces a completely redesigned chat input experience with rich context support through an intuitive typeahead system. Users can now seamlessly reference notes, folders, tags, URLs, and tools directly in their messages using familiar syntax like
@note
,#tag
, and/command
.Key Features
🎯 Smart Typeahead System
@
mentions: Use@
to reference notes, folders, tags, URLs, or tools with intelligent autocomplete[[
for notes: Type[[
to search and insert notes into your message as interactive pills#
for tags: Type#
to quickly add Obsidian tags to provide context/
commands: Access slash commands for quick actions and custom prompts📝 Enhanced Message Editing
🎬 YouTube Integration
🎨 Visual Improvements
🚀 Performance & UX Enhancements
User Benefits
[[
,@
,#
,/
) match user expectationsTechnical Improvements
Breaking Changes
None - all existing functionality is preserved with enhanced capabilities.
Testing